Issue 1158513002: Make clang plugin diagnostics errors again on Windows GN builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1158513002: Make clang plugin diagnostics errors again on Windows GN builds. (Closed)

Created:
5 years, 7 months ago by dcheng

Modified:
5 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -10 lines)			Patch
	M	build/config/clang/BUILD.gn	View		1 chunk	+0 lines, -10 lines	0 comments	Download

Total messages: 7 (2 generated)

Nico

lgtm, thanks Filed http://code.google.com/p/chromium/issues/detail?id=491209 for getting clang/win working in the gn build in general

5 years, 7 months ago (2015-05-22 16:28:03 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158513002/1

5 years, 7 months ago (2015-05-22 16:30:02 UTC) #5

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/7b3638806824d77dd66453029df40fa99772e863 Cr-Commit-Position: refs/heads/master@{#331121}

5 years, 7 months ago (2015-05-22 16:42:14 UTC) #6

dcheng

5 years, 7 months ago (2015-05-22 16:42:24 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7b3638806824d77dd66453029df40fa99772e863 (presubmit successful).