| OLD | NEW |
| 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 import("clang.gni") | 5 import("clang.gni") |
| 6 | 6 |
| 7 config("find_bad_constructs") { | 7 config("find_bad_constructs") { |
| 8 if (clang_use_chrome_plugins) { | 8 if (clang_use_chrome_plugins) { |
| 9 cflags = [] | 9 cflags = [] |
| 10 | 10 |
| (...skipping 13 matching lines...) Expand all Loading... |
| 24 cflags += [ | 24 cflags += [ |
| 25 "-Xclang", | 25 "-Xclang", |
| 26 "-load", | 26 "-load", |
| 27 "-Xclang", | 27 "-Xclang", |
| 28 rebase_path( | 28 rebase_path( |
| 29 "//third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.s
o", | 29 "//third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.s
o", |
| 30 root_build_dir), | 30 root_build_dir), |
| 31 ] | 31 ] |
| 32 } | 32 } |
| 33 | 33 |
| 34 if (is_win) { | |
| 35 # Don't error on plugin warnings on Windows until pre-existing warnings | |
| 36 # are cleaned up. https://crbug.com/467287 | |
| 37 cflags += [ | |
| 38 "-Xclang", | |
| 39 "-plugin-arg-find-bad-constructs", | |
| 40 "-Xclang warn-only", | |
| 41 ] | |
| 42 } | |
| 43 | |
| 44 cflags += [ | 34 cflags += [ |
| 45 "-Xclang", | 35 "-Xclang", |
| 46 "-add-plugin", | 36 "-add-plugin", |
| 47 "-Xclang", | 37 "-Xclang", |
| 48 "find-bad-constructs", | 38 "find-bad-constructs", |
| 49 ] | 39 ] |
| 50 } | 40 } |
| 51 } | 41 } |
| 52 | 42 |
| 53 # Enables some extra Clang-specific warnings. Some third-party code won't | 43 # Enables some extra Clang-specific warnings. Some third-party code won't |
| 54 # compile with these so may want to remove this config. | 44 # compile with these so may want to remove this config. |
| 55 config("extra_warnings") { | 45 config("extra_warnings") { |
| 56 cflags = [ | 46 cflags = [ |
| 57 "-Wheader-hygiene", | 47 "-Wheader-hygiene", |
| 58 | 48 |
| 59 # Warns when a const char[] is converted to bool. | 49 # Warns when a const char[] is converted to bool. |
| 60 "-Wstring-conversion", | 50 "-Wstring-conversion", |
| 61 ] | 51 ] |
| 62 } | 52 } |
| OLD | NEW |