build/config/clang/BUILD.gn - Issue 1158513002: Make clang plugin diagnostics errors again on Windows GN builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/clang/BUILD.gn

Issue 1158513002: Make clang plugin diagnostics errors again on Windows GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/clang/BUILD.gn

diff --git a/build/config/clang/BUILD.gn b/build/config/clang/BUILD.gn

index e79a7b93d82eb4ea9e74449cc46bb64426f8a792..3d965003b89ac0632f7d0fb63213fde81aa14f37 100644

--- a/build/config/clang/BUILD.gn

+++ b/build/config/clang/BUILD.gn

@@ -31,16 +31,6 @@ config("find_bad_constructs") {

]

}

- if (is_win) {

- # Don't error on plugin warnings on Windows until pre-existing warnings

- # are cleaned up. https://crbug.com/467287

- cflags += [

- "-Xclang",

- "-plugin-arg-find-bad-constructs",

- "-Xclang warn-only",

- ]

- }

cflags += [

"-Xclang",

"-add-plugin",

« no previous file with comments | « no previous file | no next file » | no next file with comments »