Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1158453004: Revert of Move DstCoordTexture to GrXP, rename and remove the word "copy" from dstcopytexture names. (Closed)

Created:
5 years, 7 months ago by bungeman-skia
Modified:
5 years, 7 months ago
Reviewers:
egdaniel, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@copy
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Move DstCoordTexture to GrXP, rename and remove the word "copy" from dstcopytexture names. (patchset #6 id:100001 of https://codereview.chromium.org/1132093004/) Reason for revert: This is asserting on GTX660 bots with '!dst'. This may just be catching an existing issue. https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Debug/builds/622/steps/dm/logs/stdio https://build.chromium.org/p/client.skia/builders/Test-Win7-MSVC-ShuttleA-GPU-HD2000-x86-Debug-ANGLE/builds/209/steps/dm/logs/stdio https://build.chromium.org/p/client.skia/builders/Test-Win8-MSVC-ShuttleA-GPU-GTX660-x86_64-Debug/builds/318/steps/dm/logs/stdio Original issue's description: > Move DstCoordTexture to GrXP, rename and remove the word "copy" from dstcopytexture names. > > Committed: https://skia.googlesource.com/skia/+/bb106b5f6ee18f7453b63f3a95f421b60a957f39 TBR=egdaniel@google.com,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/d23a395d519835f78630aaea3f2a2c30ecdffe87

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -177 lines) Patch
M include/gpu/GrTexture.h View 1 chunk +39 lines, -0 lines 0 comments Download
M include/gpu/GrXferProcessor.h View 8 chunks +20 lines, -62 lines 0 comments Download
M include/gpu/effects/GrCoverageSetOpXP.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/effects/GrPorterDuffXferProcessor.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkArithmeticMode_gpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 4 chunks +8 lines, -7 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 3 chunks +6 lines, -7 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/GrPipeline.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrPipeline.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/GrPipelineBuilder.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/GrXferProcessor.cpp View 4 chunks +18 lines, -17 lines 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 4 chunks +8 lines, -7 lines 0 comments Download
M src/gpu/effects/GrCustomXfermodePriv.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDisableColorXP.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDisableColorXP.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 4 chunks +8 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLProgram.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProgramDesc.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLXferProcessor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLXferProcessor.cpp View 3 chunks +24 lines, -24 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M tests/GrPorterDuffTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bungeman-skia
Created Revert of Move DstCoordTexture to GrXP, rename and remove the word "copy" from dstcopytexture ...
5 years, 7 months ago (2015-05-22 22:22:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158453004/1
5 years, 7 months ago (2015-05-22 22:22:36 UTC) #2
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 22:22:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d23a395d519835f78630aaea3f2a2c30ecdffe87

Powered by Google App Engine
This is Rietveld 408576698