Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 1158193006: Converted bare pointer to scoped_ptr<> in net/socket and net/http (Closed)

Created:
5 years, 6 months ago by ketan.goyal
Modified:
5 years, 6 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Converted bare pointer to scoped_ptr<> in net/socket and net/http BUG=479898 R=eroman@chromium.org Committed: https://crrev.com/f84eda918f068e9b70aacca8581a5b05139af2c1 Cr-Commit-Position: refs/heads/master@{#332587}

Patch Set 1 #

Total comments: 7

Patch Set 2 : Incorporating review comments #

Patch Set 3 : Fixed failed net unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -29 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_proxy_client_socket_pool.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M net/socket/client_socket_pool.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/socket/client_socket_pool_base.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M net/socket/client_socket_pool_base.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/socket/client_socket_pool_base_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/socket/socks_client_socket_pool.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/socks_client_socket_pool.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M net/socket/ssl_client_socket_pool.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M net/socket/transport_client_socket_pool.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/transport_client_socket_pool.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/socket/websocket_transport_client_socket_pool.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/websocket_transport_client_socket_pool.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (3 generated)
ketan.goyal
5 years, 6 months ago (2015-06-01 14:01:31 UTC) #1
ketan.goyal
Please take look
5 years, 6 months ago (2015-06-01 14:02:24 UTC) #2
eroman
You must sign the Google contributor liscence agreement: https://www.chromium.org/developers/contributing-code https://codereview.chromium.org/1158193006/diff/1/net/http/http_proxy_client_socket_pool.cc File net/http/http_proxy_client_socket_pool.cc (right): https://codereview.chromium.org/1158193006/diff/1/net/http/http_proxy_client_socket_pool.cc#newcode519 net/http/http_proxy_client_socket_pool.cc:519: ...
5 years, 6 months ago (2015-06-01 17:07:23 UTC) #3
ketan.goyal
On 2015/06/01 17:07:23, eroman wrote: Added to CLA list and review comments incorporated Please take ...
5 years, 6 months ago (2015-06-02 06:28:47 UTC) #4
eroman
lgtm
5 years, 6 months ago (2015-06-02 20:59:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158193006/20001
5 years, 6 months ago (2015-06-02 20:59:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/67699)
5 years, 6 months ago (2015-06-02 21:13:32 UTC) #9
eroman
Doesn't look like the net_unittests target compiles with this change
5 years, 6 months ago (2015-06-02 21:13:48 UTC) #10
ketan.goyal
On 2015/06/02 21:13:48, eroman wrote: > Doesn't look like the net_unittests target compiles with this ...
5 years, 6 months ago (2015-06-03 07:26:41 UTC) #11
eroman
lgtm
5 years, 6 months ago (2015-06-03 08:07:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158193006/40001
5 years, 6 months ago (2015-06-03 08:38:58 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-03 10:53:41 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 10:54:37 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f84eda918f068e9b70aacca8581a5b05139af2c1
Cr-Commit-Position: refs/heads/master@{#332587}

Powered by Google App Engine
This is Rietveld 408576698