Converted bare pointer to scoped_ptr<> in net/socket and net/http

Converted bare pointer to scoped_ptr<> in net/socket and net/http

BUG=479898
R=eroman@chromium.org

Committed: https://crrev.com/f84eda918f068e9b70aacca8581a5b05139af2c1
Cr-Commit-Position: refs/heads/master@{#332587}

[ketan.goyal, 2015-06-01 14:02:24]

Please take look

[eroman, 2015-06-01 17:07:23]

You must sign the Google contributor liscence agreement:
https://www.chromium.org/developers/contributing-code

https://codereview.chromium.org/1158193006/diff/1/net/http/http_proxy_client_...
File net/http/http_proxy_client_socket_pool.cc (right):

https://codereview.chromium.org/1158193006/diff/1/net/http/http_proxy_client_...
net/http/http_proxy_client_socket_pool.cc:519: dict(base_.GetInfoAsValue(name,
type).Pass());
No need for .Pass(), can directly assign

https://codereview.chromium.org/1158193006/diff/1/net/socket/client_socket_po...
File net/socket/client_socket_pool.h (right):

https://codereview.chromium.org/1158193006/diff/1/net/socket/client_socket_po...
net/socket/client_socket_pool.h:161: // DictionaryValue.  Caller takes
possession of the returned value.
Remove comment about caller taking possesion

https://codereview.chromium.org/1158193006/diff/1/net/socket/client_socket_po...
File net/socket/client_socket_pool_base.h (right):

https://codereview.chromium.org/1158193006/diff/1/net/socket/client_socket_po...
net/socket/client_socket_pool_base.h:330: const std::string& type) const;
Have you re-run "git cl format" ?

https://codereview.chromium.org/1158193006/diff/1/net/socket/client_socket_po...
net/socket/client_socket_pool_base.h:832: return helper_.GetInfoAsValue(name,
type).Pass();
Pass() is unnecessary

https://codereview.chromium.org/1158193006/diff/1/net/socket/socks_client_soc...
File net/socket/socks_client_socket_pool.cc (right):

https://codereview.chromium.org/1158193006/diff/1/net/socket/socks_client_soc...
net/socket/socks_client_socket_pool.cc:274: dict(base_.GetInfoAsValue(name,
type).Pass());
No need for Pass()

https://codereview.chromium.org/1158193006/diff/1/net/socket/ssl_client_socke...
File net/socket/ssl_client_socket_pool.cc (right):

https://codereview.chromium.org/1158193006/diff/1/net/socket/ssl_client_socke...
net/socket/ssl_client_socket_pool.cc:625: dict(base_.GetInfoAsValue(name,
type).Pass());
No need for Pass

https://codereview.chromium.org/1158193006/diff/1/net/socket/transport_client...
File net/socket/transport_client_socket_pool.cc (right):

https://codereview.chromium.org/1158193006/diff/1/net/socket/transport_client...
net/socket/transport_client_socket_pool.cc:616: return
base_.GetInfoAsValue(name, type).Pass();
No need for Pass

[ketan.goyal, 2015-06-02 06:28:47]

On 2015/06/01 17:07:23, eroman wrote:

Added to CLA list and review comments incorporated 

Please take look again

[eroman, 2015-06-02 20:59:23]

The CQ bit was checked by eroman@chromium.org

[eroman, 2015-06-02 20:59:24]

lgtm

[commit-bot: I haz the power, 2015-06-02 20:59:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158193006/20001

[commit-bot: I haz the power, 2015-06-02 21:13:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-02 21:13:32]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[eroman, 2015-06-02 21:13:48]

Doesn't look like the net_unittests target compiles with this change

[ketan.goyal, 2015-06-03 07:26:41]

On 2015/06/02 21:13:48, eroman wrote:
> Doesn't look like the net_unittests target compiles with this change

Failed net unit tests Fixed.

Please take look again

[eroman, 2015-06-03 08:07:19]

lgtm

[ketan.goyal, 2015-06-03 08:37:37]

The CQ bit was checked by ketan.goyal@samsung.com

[commit-bot: I haz the power, 2015-06-03 08:38:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158193006/40001

[commit-bot: I haz the power, 2015-06-03 10:53:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-03 10:54:37]

Patchset 3 (id:??) landed as
https://crrev.com/f84eda918f068e9b70aacca8581a5b05139af2c1
Cr-Commit-Position: refs/heads/master@{#332587}