net/socket/socks_client_socket_pool.h - Issue 1158193006: Converted bare pointer to scoped_ptr<> in net/socket and net/http

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/socks_client_socket_pool.h

Issue 1158193006: Converted bare pointer to scoped_ptr<> in net/socket and net/http (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed failed net unit tests Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/socks_client_socket_pool.h

diff --git a/net/socket/socks_client_socket_pool.h b/net/socket/socks_client_socket_pool.h

index 69bcf00f076851953aa9db9be8638affccb854ae..77dbb4988a8aff24b521f4e3429219caf2f6c735 100644

--- a/net/socket/socks_client_socket_pool.h

+++ b/net/socket/socks_client_socket_pool.h

@@ -148,7 +148,7 @@ class NET_EXPORT_PRIVATE SOCKSClientSocketPool

LoadState GetLoadState(const std::string& group_name,

const ClientSocketHandle* handle) const override;

- base::DictionaryValue* GetInfoAsValue(

+ scoped_ptr<base::DictionaryValue> GetInfoAsValue(

const std::string& name,

const std::string& type,

bool include_nested_pools) const override;

« no previous file with comments | « net/socket/client_socket_pool_base_unittest.cc ('k') | net/socket/socks_client_socket_pool.cc » ('j') | no next file with comments »