Converted bare pointer to scoped_ptr<> in net/socket and net/http

net/socket/client_socket_pool_base.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // A ClientSocketPoolBase is used to restrict the number of sockets open at
 // a time.  It also maintains a list of idle persistent sockets for reuse.
 // Subclasses of ClientSocketPool should compose ClientSocketPoolBase to handle
 // the core logic of (1) restricting the number of active (connected or
 // connecting) sockets per "group" (generally speaking, the hostname), (2)
 // maintaining a per-group list of idle, persistent sockets for reuse, and (3)
@@ skipping 308 matching lines @@
   // TODO(willchan): Consider a better algorithm for doing this.  Perhaps we
   // should keep an ordered list of idle sockets, and close them in order.
   // Requires maintaining more state.  It's not clear if it's worth it since
   // I'm not sure if we hit this situation often.
   bool CloseOneIdleSocket();
 
   // Checks higher layered pools to see if they can close an idle connection.
   bool CloseOneIdleConnectionInHigherLayeredPool();
 
   // See ClientSocketPool::GetInfoAsValue for documentation on this function.
-  base::DictionaryValue* GetInfoAsValue(const std::string& name,
+  scoped_ptr<base::DictionaryValue> GetInfoAsValue(const std::string& name,
                                         const std::string& type) const;

[eroman, 2015/06/01 17:07:23]

Have you re-run "git cl format" ?

 
   base::TimeDelta ConnectionTimeout() const {
     return connect_job_factory_->ConnectionTimeout();
   }
 
   static bool connect_backup_jobs_enabled();
   static bool set_connect_backup_jobs_enabled(bool enabled);
 
   void EnableConnectBackupJobs();
 
@@ skipping 479 matching lines @@
   }
 
   bool HasGroup(const std::string& group_name) const {
     return helper_.HasGroup(group_name);
   }
 
   void CleanupIdleSockets(bool force) {
     return helper_.CleanupIdleSockets(force);
   }
 
-  base::DictionaryValue* GetInfoAsValue(const std::string& name,
+  scoped_ptr<base::DictionaryValue> GetInfoAsValue(const std::string& name,
                                         const std::string& type) const {
-    return helper_.GetInfoAsValue(name, type);
+    return helper_.GetInfoAsValue(name, type).Pass();

[eroman, 2015/06/01 17:07:23]

Pass() is unnecessary

   }
 
   base::TimeDelta ConnectionTimeout() const {
     return helper_.ConnectionTimeout();
   }
 
   void EnableConnectBackupJobs() { helper_.EnableConnectBackupJobs(); }
 
   bool CloseOneIdleSocket() { return helper_.CloseOneIdleSocket(); }
 
@@ skipping 34 matching lines @@
   };
 
   internal::ClientSocketPoolBaseHelper helper_;
 
   DISALLOW_COPY_AND_ASSIGN(ClientSocketPoolBase);
 };
 
 }  // namespace net
 
 #endif  // NET_SOCKET_CLIENT_SOCKET_POOL_BASE_H_