Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: src/pending-compilation-error-handler.cc

Issue 1158013003: Increase the chance of printing a useful error when bootstrapping fails (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix type handling in PendingCompilationErrorHandler Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/isolate.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/pending-compilation-error-handler.cc
diff --git a/src/pending-compilation-error-handler.cc b/src/pending-compilation-error-handler.cc
index 098db62acc31d27ae8fdc98e2a879c1dffa3ee80..10a10320a6e788fac41b920c939149aec651f65b 100644
--- a/src/pending-compilation-error-handler.cc
+++ b/src/pending-compilation-error-handler.cc
@@ -41,6 +41,11 @@ void PendingCompilationErrorHandler::ThrowPendingError(Isolate* isolate,
break;
}
+ if (!error->IsJSObject()) {
+ isolate->Throw(*error, &location);
+ return;
+ }
+
Handle<JSObject> jserror = Handle<JSObject>::cast(error);
Handle<Name> key_start_pos = factory->error_start_pos_symbol();
« no previous file with comments | « src/isolate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698