Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: src/isolate.cc

Issue 1158013003: Increase the chance of printing a useful error when bootstrapping fails (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix type handling in PendingCompilationErrorHandler Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/factory.cc ('k') | src/pending-compilation-error-handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index 93005e3164bf735039cef29bcf78dba28c1f6357..1573629b917793ba9b6c7b66b09803480dc1fb17 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -937,6 +937,9 @@ void ReportBootstrappingException(Handle<Object> exception,
"Extension or internal compilation error in %s at line %d.\n",
String::cast(location->script()->name())->ToCString().get(),
line_number);
+ } else if (exception->IsString()) {
+ base::OS::PrintError("Extension or internal compilation error: %s.\n",
+ String::cast(*exception)->ToCString().get());
} else {
base::OS::PrintError("Extension or internal compilation error.\n");
}
« no previous file with comments | « src/factory.cc ('k') | src/pending-compilation-error-handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698