Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: src/pending-compilation-error-handler.cc

Issue 1158013003: Increase the chance of printing a useful error when bootstrapping fails (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix type handling in PendingCompilationErrorHandler Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/isolate.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/pending-compilation-error-handler.h" 5 #include "src/pending-compilation-error-handler.h"
6 6
7 #include "src/debug.h" 7 #include "src/debug.h"
8 #include "src/handles.h" 8 #include "src/handles.h"
9 #include "src/isolate.h" 9 #include "src/isolate.h"
10 #include "src/messages.h" 10 #include "src/messages.h"
(...skipping 23 matching lines...) Expand all
34 error = factory->NewError("MakeReferenceError", message_, argument); 34 error = factory->NewError("MakeReferenceError", message_, argument);
35 break; 35 break;
36 case kSyntaxError: 36 case kSyntaxError:
37 error = factory->NewError("MakeSyntaxError", message_, argument); 37 error = factory->NewError("MakeSyntaxError", message_, argument);
38 break; 38 break;
39 default: 39 default:
40 UNREACHABLE(); 40 UNREACHABLE();
41 break; 41 break;
42 } 42 }
43 43
44 if (!error->IsJSObject()) {
45 isolate->Throw(*error, &location);
46 return;
47 }
48
44 Handle<JSObject> jserror = Handle<JSObject>::cast(error); 49 Handle<JSObject> jserror = Handle<JSObject>::cast(error);
45 50
46 Handle<Name> key_start_pos = factory->error_start_pos_symbol(); 51 Handle<Name> key_start_pos = factory->error_start_pos_symbol();
47 JSObject::SetProperty(jserror, key_start_pos, 52 JSObject::SetProperty(jserror, key_start_pos,
48 handle(Smi::FromInt(location.start_pos()), isolate), 53 handle(Smi::FromInt(location.start_pos()), isolate),
49 SLOPPY).Check(); 54 SLOPPY).Check();
50 55
51 Handle<Name> key_end_pos = factory->error_end_pos_symbol(); 56 Handle<Name> key_end_pos = factory->error_end_pos_symbol();
52 JSObject::SetProperty(jserror, key_end_pos, 57 JSObject::SetProperty(jserror, key_end_pos,
53 handle(Smi::FromInt(location.end_pos()), isolate), 58 handle(Smi::FromInt(location.end_pos()), isolate),
54 SLOPPY).Check(); 59 SLOPPY).Check();
55 60
56 Handle<Name> key_script = factory->error_script_symbol(); 61 Handle<Name> key_script = factory->error_script_symbol();
57 JSObject::SetProperty(jserror, key_script, script, SLOPPY).Check(); 62 JSObject::SetProperty(jserror, key_script, script, SLOPPY).Check();
58 63
59 isolate->Throw(*error, &location); 64 isolate->Throw(*error, &location);
60 } 65 }
61 } // namespace internal 66 } // namespace internal
62 } // namespace v8 67 } // namespace v8
OLDNEW
« no previous file with comments | « src/isolate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698