Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1158013003: Increase the chance of printing a useful error when bootstrapping fails (Closed)

Created:
5 years, 6 months ago by adamk
Modified:
5 years, 6 months ago
Reviewers:
Yang
CC:
v8-dev, dehrenberg
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Increase the chance of printing a useful error when bootstrapping fails Two changes: - In ReportBootstrappingException, if all we have is a string, it seems better to print that than nothing. - In Factory::NewError, there's no use trying to call into the builtins if compilation of the builtins is causing the exception (this currently results in a cryptic segfault if we trigger, say, a ReferenceError when executing builtins script during bootstrapping). Committed: https://crrev.com/0be9c69e6ce765a3ed2c2a385b807b5b5e4221dd Cr-Commit-Position: refs/heads/master@{#28912}

Patch Set 1 #

Patch Set 2 : Fix type handling in PendingCompilationErrorHandler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M src/factory.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/pending-compilation-error-handler.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
5 years, 6 months ago (2015-06-02 19:43:29 UTC) #2
Yang
On 2015/06/02 19:43:29, adamk wrote: LGTM!
5 years, 6 months ago (2015-06-08 08:55:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158013003/20001
5 years, 6 months ago (2015-06-10 16:39:17 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-10 17:42:07 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 17:42:26 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0be9c69e6ce765a3ed2c2a385b807b5b5e4221dd
Cr-Commit-Position: refs/heads/master@{#28912}

Powered by Google App Engine
This is Rietveld 408576698