Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1157843008: Fix paint invalidation for SVG with outline-offset (Closed)

Created:
5 years, 6 months ago by fs
Modified:
5 years, 6 months ago
Reviewers:
pdr., f(malita)
CC:
blink-reviews, krit, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, blink-reviews-rendering, f(malita), jchaffraix+rendering, gyuyoung2, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix paint invalidation for SVG with outline-offset The paint invalidation code did not factor in the outline-offset, leading to too small repaint rectangles. Use ComputedStyle::outlineSize() when inflating the paint invalidation rect instead. If the outline-style is 'auto', then use the GC::focusRingOutsetExtent function - this leads to smaller paint inv. rects where this applies (like in tests svg/repaint/focus-element.html and svg/custom/focus-ring.svg). BUG=495666 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196484

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -21 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/svg/repaint/outline-offset-shape.html View 1 chunk +17 lines, -0 lines 0 comments Download
A + LayoutTests/svg/repaint/outline-offset-shape-expected.txt View 1 chunk +4 lines, -1 line 0 comments Download
A LayoutTests/svg/repaint/outline-offset-text.html View 1 chunk +20 lines, -0 lines 0 comments Download
A + LayoutTests/svg/repaint/outline-offset-text-expected.txt View 1 chunk +6 lines, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGBlock.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGInline.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGModelObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/SVGLayoutSupport.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/SVGLayoutSupport.cpp View 2 chunks +21 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
5 years, 6 months ago (2015-06-03 16:15:59 UTC) #2
fs
5 years, 6 months ago (2015-06-03 20:20:21 UTC) #3
f(malita)
lgtm
5 years, 6 months ago (2015-06-03 20:26:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157843008/1
5 years, 6 months ago (2015-06-04 09:07:28 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 09:11:07 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196484

Powered by Google App Engine
This is Rietveld 408576698