Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: Source/core/layout/svg/LayoutSVGBlock.cpp

Issue 1157843008: Fix paint invalidation for SVG with outline-offset (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Apple Computer, Inc. 2 * Copyright (C) 2006 Apple Computer, Inc.
3 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org> 3 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org>
4 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 4 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 SVGLayoutSupport::mapLocalToContainer(this, paintInvalidationContainer, tran sformState, wasFixed, paintInvalidationState); 97 SVGLayoutSupport::mapLocalToContainer(this, paintInvalidationContainer, tran sformState, wasFixed, paintInvalidationState);
98 } 98 }
99 99
100 const LayoutObject* LayoutSVGBlock::pushMappingToContainer(const LayoutBoxModelO bject* ancestorToStopAt, LayoutGeometryMap& geometryMap) const 100 const LayoutObject* LayoutSVGBlock::pushMappingToContainer(const LayoutBoxModelO bject* ancestorToStopAt, LayoutGeometryMap& geometryMap) const
101 { 101 {
102 return SVGLayoutSupport::pushMappingToContainer(this, ancestorToStopAt, geom etryMap); 102 return SVGLayoutSupport::pushMappingToContainer(this, ancestorToStopAt, geom etryMap);
103 } 103 }
104 104
105 LayoutRect LayoutSVGBlock::clippedOverflowRectForPaintInvalidation(const LayoutB oxModelObject* paintInvalidationContainer, const PaintInvalidationState* paintIn validationState) const 105 LayoutRect LayoutSVGBlock::clippedOverflowRectForPaintInvalidation(const LayoutB oxModelObject* paintInvalidationContainer, const PaintInvalidationState* paintIn validationState) const
106 { 106 {
107 return SVGLayoutSupport::clippedOverflowRectForPaintInvalidation(this, paint InvalidationContainer, paintInvalidationState); 107 return SVGLayoutSupport::clippedOverflowRectForPaintInvalidation(*this, pain tInvalidationContainer, paintInvalidationState);
108 } 108 }
109 109
110 void LayoutSVGBlock::mapRectToPaintInvalidationBacking(const LayoutBoxModelObjec t* paintInvalidationContainer, LayoutRect& rect, const PaintInvalidationState* p aintInvalidationState) const 110 void LayoutSVGBlock::mapRectToPaintInvalidationBacking(const LayoutBoxModelObjec t* paintInvalidationContainer, LayoutRect& rect, const PaintInvalidationState* p aintInvalidationState) const
111 { 111 {
112 FloatRect paintInvalidationRect = rect; 112 FloatRect paintInvalidationRect = rect;
113 paintInvalidationRect.inflate(style()->outlineWidth()); 113 const LayoutSVGRoot& svgRoot = SVGLayoutSupport::mapRectToSVGRootForPaintInv alidation(*this, paintInvalidationRect, rect);
114 const LayoutSVGRoot& svgRoot = SVGLayoutSupport::mapRectToSVGRootForPaintInv alidation(this, paintInvalidationRect, rect);
115 svgRoot.mapRectToPaintInvalidationBacking(paintInvalidationContainer, rect, paintInvalidationState); 114 svgRoot.mapRectToPaintInvalidationBacking(paintInvalidationContainer, rect, paintInvalidationState);
116 } 115 }
117 116
118 bool LayoutSVGBlock::nodeAtPoint(HitTestResult&, const HitTestLocation&, const L ayoutPoint&, HitTestAction) 117 bool LayoutSVGBlock::nodeAtPoint(HitTestResult&, const HitTestLocation&, const L ayoutPoint&, HitTestAction)
119 { 118 {
120 ASSERT_NOT_REACHED(); 119 ASSERT_NOT_REACHED();
121 return false; 120 return false;
122 } 121 }
123 122
124 void LayoutSVGBlock::invalidateTreeIfNeeded(PaintInvalidationState& paintInvalid ationState) 123 void LayoutSVGBlock::invalidateTreeIfNeeded(PaintInvalidationState& paintInvalid ationState)
125 { 124 {
126 if (!shouldCheckForPaintInvalidation(paintInvalidationState)) 125 if (!shouldCheckForPaintInvalidation(paintInvalidationState))
127 return; 126 return;
128 127
129 ForceHorriblySlowRectMapping slowRectMapping(&paintInvalidationState); 128 ForceHorriblySlowRectMapping slowRectMapping(&paintInvalidationState);
130 LayoutBlockFlow::invalidateTreeIfNeeded(paintInvalidationState); 129 LayoutBlockFlow::invalidateTreeIfNeeded(paintInvalidationState);
131 } 130 }
132 131
133 } 132 }
OLDNEW
« no previous file with comments | « LayoutTests/svg/repaint/outline-offset-text-expected.txt ('k') | Source/core/layout/svg/LayoutSVGInline.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698