Move SkGpuDevice::internalDrawPath to GrBlurUtils::drawPathWithMaskFilter

Move SkGpuDevice::internalDrawPath to GrBlurUtils::drawPathWithMaskFilter

This CL is ugly but it:

removes the stored SkGpuDevice back pointer from GrTextContext (at the cost of passing more parameters) 
moves SkGpuDevice::internalDrawPath to GrDrawContext::drawPathFull

Unfortunately, the GrTextContext-derived classes still need the SkGpuDevice for filterTextFlags calls but I will try removing that in a separate CL.

Committed: https://skia.googlesource.com/skia/+/ccb1b5751075506b4615d2112889d01ee8ad6436

[robertphillips, 2015-05-27 13:02:30]

robertphillips@google.com changed reviewers:
+ joshualitt@chromium.org, joshualitt@google.com

[robertphillips, 2015-05-27 13:02:41]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[joshualitt, 2015-05-27 15:02:29]

lgtm, one minor nit

https://codereview.chromium.org/1157773003/diff/60001/include/gpu/GrDrawConte...
File include/gpu/GrDrawContext.h (right):

https://codereview.chromium.org/1157773003/diff/60001/include/gpu/GrDrawConte...
include/gpu/GrDrawContext.h:184: void drawPathFull(GrContext* context,
drawPathWithMaskFilter?  Kind of a mouthful, but at least its descriptive.

https://codereview.chromium.org/1157773003/diff/60001/src/gpu/GrAtlasTextCont...
File src/gpu/GrAtlasTextContext.cpp (right):

https://codereview.chromium.org/1157773003/diff/60001/src/gpu/GrAtlasTextCont...
src/gpu/GrAtlasTextContext.cpp:502:
runPaint.setFlags(gpuDevice->filterTextFlags(runPaint));
:(

[bsalomon, 2015-05-27 15:15:55]

https://codereview.chromium.org/1157773003/diff/60001/include/gpu/GrDrawConte...
File include/gpu/GrDrawContext.h (right):

https://codereview.chromium.org/1157773003/diff/60001/include/gpu/GrDrawConte...
include/gpu/GrDrawContext.h:184: void drawPathFull(GrContext* context,
Hm... I feel like this is really blurring (get it?) the distinction between
SkGpuDevice and GrDrawContext. The split now is that the SkPaint is digested in
GpuDevice and turned into Gr-constructs.

Is it possible this could be written as a utility that is shared by multiple
clients that sits on top of GrDrawContext?

[robertphillips, 2015-05-27 15:55:23]

PTAL

https://codereview.chromium.org/1157773003/diff/60001/include/gpu/GrDrawConte...
File include/gpu/GrDrawContext.h (right):

https://codereview.chromium.org/1157773003/diff/60001/include/gpu/GrDrawConte...
include/gpu/GrDrawContext.h:184: void drawPathFull(GrContext* context,
On 2015/05/27 15:02:29, joshualitt wrote:
> drawPathWithMaskFilter?  Kind of a mouthful, but at least its descriptive.

Done.

[bsalomon, 2015-05-27 16:06:59]

lgtm

[robertphillips, 2015-05-27 17:39:45]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[robertphillips, 2015-05-27 17:39:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
joshualitt@google.com
Link to the patchset: https://codereview.chromium.org/1157773003/#ps120001
(title: "more cleanup")

[commit-bot: I haz the power, 2015-05-27 17:40:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1157773003/120001

[commit-bot: I haz the power, 2015-05-27 17:45:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-27 17:45:53]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-05-27 18:01:50]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2015-05-27 18:02:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1157773003/120001

[commit-bot: I haz the power, 2015-05-27 18:02:58]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/ccb1b5751075506b4615d2112889d01ee8ad6436