Move SkGpuDevice::internalDrawPath to GrBlurUtils::drawPathWithMaskFilter

include/gpu/GrDrawContext.h

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef GrDrawContext_DEFINED
 #define GrDrawContext_DEFINED
 
 #include "GrColor.h"
 #include "SkRefCnt.h"
 
 class GrBatch;
 class GrClip;
 class GrContext;
 class GrDrawTarget;
 class GrPaint;
 class GrPathProcessor;
 class GrPathRange;
 class GrPipelineBuilder;
 class GrRenderTarget;
 class GrStrokeInfo;
 class GrSurface;
 struct SkIPoint;
 struct SkIRect;
 class SkMatrix;
+class SkPaint;
 class SkPath;
 struct SkPoint;
 struct SkRect;
 class SkRRect;
 
 
 /*
  * A helper object to orchestrate draws
  */
 class SK_API GrDrawContext : public SkRefCnt {
@@ skipping 131 matching lines @@
      * @param strokeInfo    the stroke information (width, join, cap) and
      *                      the dash information (intervals, count, phase).
      */
     void drawPath(GrRenderTarget*,
                   const GrClip&,
                   const GrPaint&,
                   const SkMatrix& viewMatrix,
                   const SkPath&,
                   const GrStrokeInfo&);
 
+
+    /**
+     * Draw a path handling the mask filter if present.
+     */
+    void drawPathFull(GrContext* context,

[joshualitt, 2015/05/27 15:02:29]

drawPathWithMaskFilter?  Kind of a mouthful, but at least its descriptive.

[bsalomon, 2015/05/27 15:15:55]

Hm... I feel like this is really blurring (get it?) the distinction between
SkGpuDevice and GrDrawContext. The split now is that the SkPaint is digested in
GpuDevice and turned into Gr-constructs.

Is it possible this could be written as a utility that is shared by multiple
clients that sits on top of GrDrawContext?

[robertphillips, 2015/05/27 15:55:23]

Done.

+                      GrRenderTarget* rt,
+                      const GrClip& clip,
+                      const SkPath& origSrcPath,
+                      const SkPaint& paint,
+                      const SkMatrix& origViewMatrix,
+                      const SkMatrix* prePathMatrix,
+                      const SkIRect& clipBounds,
+                      bool pathIsMutable);
+
     /**
      * Draws vertices with a paint.
      *
      * @param   paint           describes how to color pixels.
      * @param   viewMatrix      transformation matrix
      * @param   primitiveType   primitives type to draw.
      * @param   vertexCount     number of vertices.
      * @param   positions       array of vertex positions, required.
      * @param   texCoords       optional array of texture coordinates used
      *                          to access the paint.
@@ skipping 54 matching lines @@
                           GrColor,
                           bool useAA,
                           const SkPath&,
                           const GrStrokeInfo&);
 
     GrContext*                     fContext;     // owning context -> no ref
     SkAutoTUnref<GrDrawTarget>     fDrawTarget;
 };
 
 #endif