Refactor GrGpu path rendering functions to GrPathRendering

Refactor GrGpu path rendering functions to GrPathRendering

GrGpu, GrGLGpu, GrPathRendering, GrGLPathRendering all duplicated
each others' path rendering related member functions. Make
GrPathRending the logical extension of GrGpu by removing the methods
from GrGpu. Similarly to the GL variants.

Changes includes and forward declarations due to removing
GrDrawTarget.h include from GrGpu.h. This was necessary due to
GrDrawTarget.h including GrPathRendering.h, and now GrPathRendering.h
includes GrGpu.h. (Also GrGpu.h does not need GrDrawTarget.h anymore).

Very slight runtime improvement on x86_64:
             desk_fontwipe.skp_1	 836us ->  841us	1.01x
            desk_silkfinance.skp_1	2.01ms -> 2.01ms	1x
             desk_forecastio.skp_1	7.03ms -> 7.05ms	1x
                desk_weather.skp_1	3.74ms -> 3.74ms	1x
                desk_twitter.skp_1	8.02ms -> 8.01ms	1x
                 desk_mapsvg.skp_1	5.24ms -> 5.23ms	1x
            desk_pokemonwiki.skp_1	7.06ms -> 7.03ms	1x
                 desk_sfgate.skp_1	3.19ms -> 3.17ms	1x
           tabl_cuteoverload.skp_1	2.66ms -> 2.64ms	0.99x
...
           tabl_transformice.skp_1	3.06ms -> 2.98ms	0.98x
         tabl_googlecalendar.skp_1	11.3ms ->   11ms	0.97x
            tabl_gamedeksiam.skp_1	12.8ms -> 12.4ms	0.97x
               desk_samoasvg.skp_1	10.6ms -> 10.3ms	0.97x
           tabl_worldjournal.skp_1	4.44ms ->  4.3ms	0.97x

Committed: https://skia.googlesource.com/skia/+/cabe20cafd5f091a68bbc2c0c48755ba9b61b0b7

[Kimmo Kinnunen, 2015-05-27 10:39:17]

kkinnunen@nvidia.com changed reviewers:
+ bsalomon@google.com, cdalton@nvidia.com

[Kimmo Kinnunen, 2015-05-27 10:39:18]

How about this?

[Chris Dalton, 2015-05-28 08:59:34]

I definitely like this patch. It's interesting to see that going from ~3 levels
of virtuals to 1 was enough to reduce rendering time by up to 3%.

[bsalomon, 2015-05-28 14:03:55]

Seems like a nice change to me. Curious where all the seemingly unrelated extra
includes and declarations came from? Did you use a tool to generate those? I
really like the idea of cleaning up our includes and forward declarations but if
they're tangential to this change can we land that separately?

[Kimmo Kinnunen, 2015-05-29 04:59:10]

On 2015/05/28 14:03:55, bsalomon wrote:
> Seems like a nice change to me. Curious where all the seemingly unrelated
extra
> includes and declarations came from? Did you use a tool to generate those? I
> really like the idea of cleaning up our includes and forward declarations but
if
> they're tangential to this change can we land that separately?

I don't know if you noticed the commit msg:

Changes includes and forward declarations due to removing
GrDrawTarget.h include from GrGpu.h. This was necessary due to
GrDrawTarget.h including GrPathRendering.h, and now GrPathRendering.h
includes GrGpu.h. (Also GrGpu.h does not need GrDrawTarget.h anymore).

Eg. GrGpu is included in many places. GrDrawTarget includes many headers.
Removing GrDrawTarget include from GrGpu ripples through for many other h and
cpp files.

[bsalomon, 2015-05-29 13:54:03]

On 2015/05/29 04:59:10, Kimmo Kinnunen wrote:
> On 2015/05/28 14:03:55, bsalomon wrote:
> > Seems like a nice change to me. Curious where all the seemingly unrelated
> extra
> > includes and declarations came from? Did you use a tool to generate those? I
> > really like the idea of cleaning up our includes and forward declarations
but
> if
> > they're tangential to this change can we land that separately?
> 
> I don't know if you noticed the commit msg:
> 
> Changes includes and forward declarations due to removing
> GrDrawTarget.h include from GrGpu.h. This was necessary due to
> GrDrawTarget.h including GrPathRendering.h, and now GrPathRendering.h
> includes GrGpu.h. (Also GrGpu.h does not need GrDrawTarget.h anymore).
> 
> Eg. GrGpu is included in many places. GrDrawTarget includes many headers.
> Removing GrDrawTarget include from GrGpu ripples through for many other h and
> cpp files.

Ah sorry I missed that. lgtm.

[Kimmo Kinnunen, 2015-06-01 08:23:53]

The CQ bit was checked by kkinnunen@nvidia.com

[Kimmo Kinnunen, 2015-06-01 08:23:53]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1157683006/#ps60001
(title: "rebase, remove include ordering")

[commit-bot: I haz the power, 2015-06-01 08:24:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1157683006/60001

[commit-bot: I haz the power, 2015-06-01 08:37:31]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/cabe20cafd5f091a68bbc2c0c48755ba9b61b0b7