Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 11576056: Attempt to reland r173248,173259 (Closed)

Created:
8 years ago by Zhenyao Mo
Modified:
8 years ago
Reviewers:
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, sail+watch_chromium.org, apatrick_chromium
Visibility:
Public.

Description

Attempt to reland r173248,173259 They were reverted for two reasons. 1) GpuSideBlacklist test is broken in winbots. It turns out the test is buggy, so I fixed the test in 173505 2) It broke official win build. So I reverted part of the original CL that could cause the failure: move the AMDVideoCardType enum def back to gpu_info_collector.h, although for chromium build, it doesn't need to be in the .h file. Hope this will make all bots (including official build) happe. Original CL text: Only collect GL/D3D context specific GPUInfo in GPU process Instead of collecting full GPUInfo. Basic GPUInfo are already collected at Browser process startup time. This avoids sandbox issue with libpci on linux. Also, it makes GPU startup faster. BUG=162928, 165374 TEST=manual about:gpu TBR=kbr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173533

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -344 lines) Patch
M content/browser/gpu/gpu_data_manager_impl.cc View 6 chunks +20 lines, -13 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/gpu/gpu_child_thread.cc View 4 chunks +1 line, -9 lines 0 comments Download
M content/gpu/gpu_info_collector.h View 1 chunk +20 lines, -30 lines 0 comments Download
M content/gpu/gpu_info_collector.cc View 1 chunk +30 lines, -18 lines 0 comments Download
M content/gpu/gpu_info_collector_android.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M content/gpu/gpu_info_collector_linux.cc View 3 chunks +73 lines, -69 lines 0 comments Download
M content/gpu/gpu_info_collector_mac.mm View 4 chunks +7 lines, -7 lines 0 comments Download
M content/gpu/gpu_info_collector_unittest_win.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M content/gpu/gpu_info_collector_win.cc View 5 chunks +122 lines, -123 lines 0 comments Download
M content/gpu/gpu_main.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/test/gpu/gpu_test_config.cc View 1 chunk +1 line, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698