Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1202)

Issue 11576052: Revert 173248, broke building on the official chrome/win bot: (Closed)

Created:
8 years ago by Nico
Modified:
8 years ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, sail+watch_chromium.org, apatrick_chromium
Visibility:
Public.

Description

Revert 173248, broke building on the official chrome/win bot: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/15269/steps/compile/logs/stdio#error1 155> amd_videocard_info_win.cc 155>..\third_party\amd\amd_videocard_info_win.cc(20):error C2146: syntax error : missing ';' before identifier 'GetAMDVideocardType' 155>..\third_party\amd\amd_videocard_info_win.cc(20):error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 155>..\third_party\amd\amd_videocard_info_win.cc(20):error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 155>..\third_party\amd\amd_videocard_info_win.cc(30):error C2065: 'UNKNOWN' : undeclared identifier 155>..\third_party\amd\amd_videocard_info_win.cc(38):error C2065: 'UNKNOWN' : undeclared identifier 155>..\third_party\amd\amd_videocard_info_win.cc(49):error C2065: 'STANDALONE' : undeclared identifier 155>..\third_party\amd\amd_videocard_info_win.cc(50):error C2065: 'SWITCHABLE' : undeclared identifier 155>..\third_party\amd\amd_videocard_info_win.cc(50):error C2065: 'UNKNOWN' : undeclared identifier 155>..\third_party\amd\amd_videocard_info_win.cc(50): warning C4508: 'gpu_info_collector::GetAMDVideocardType' : function should return a value; 'void' return type assumed > Only collect GL/D3D context specific GPUInfo in GPU process > > Instead of collecting full GPUInfo. Basic GPUInfo are already collected at Browser process startup time. > > This avoids sandbox issue with libpci on linux. Also, it makes GPU startup faster. > > BUG=162928, 165374 > TEST=manual about:gpu > TBR=joi > Review URL: https://codereview.chromium.org/11574049 TBR=zmo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173267

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -282 lines) Patch
M content/browser/gpu/gpu_data_manager_impl.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 4 chunks +9 lines, -1 line 0 comments Download
M content/gpu/gpu_info_collector.h View 1 chunk +38 lines, -19 lines 0 comments Download
M content/gpu/gpu_info_collector.cc View 1 chunk +18 lines, -30 lines 0 comments Download
M content/gpu/gpu_info_collector_android.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M content/gpu/gpu_info_collector_linux.cc View 3 chunks +69 lines, -73 lines 0 comments Download
M content/gpu/gpu_info_collector_mac.mm View 4 chunks +7 lines, -7 lines 0 comments Download
A + content/gpu/gpu_info_collector_unittest_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/gpu/gpu_info_collector_win.cc View 6 chunks +126 lines, -134 lines 0 comments Download
M content/gpu/gpu_main.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_test_config.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Nico
8 years ago (2012-12-15 03:23:48 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698