Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1157563005: Do not eagerly convert exception to string when creating a message object (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do not eagerly convert exception to string when creating a message object R=mstarzinger@chromium.org BUG=chromium:490680 LOG=Y Committed: https://crrev.com/36d8363c1cace489cbccfedcf3777863b12d4887 Cr-Commit-Position: refs/heads/master@{#28670}

Patch Set 1 #

Patch Set 2 : test case #

Total comments: 1

Patch Set 3 : stringify when reporting the message #

Patch Set 4 : no special case for error objects #

Patch Set 5 : revert unnecessary change to isolate.h #

Patch Set 6 : small change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -31 lines) Patch
M src/debug.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/messages.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/messages.cc View 1 2 3 4 5 3 chunks +37 lines, -18 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-490680.js View 1 2 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Yang
5 years, 7 months ago (2015-05-22 07:40:33 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/1157563005/diff/20001/test/mjsunit/regress/regress-crbug-490680.js File test/mjsunit/regress/regress-crbug-490680.js (right): https://codereview.chromium.org/1157563005/diff/20001/test/mjsunit/regress/regress-crbug-490680.js#newcode10 test/mjsunit/regress/regress-crbug-490680.js:10: } Can we also add the following construct ...
5 years, 7 months ago (2015-05-22 16:18:39 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157563005/100001
5 years, 7 months ago (2015-05-27 14:01:10 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-27 14:32:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157563005/100001
5 years, 6 months ago (2015-05-28 06:28:21 UTC) #13
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 6 months ago (2015-05-28 06:30:13 UTC) #14
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 06:30:26 UTC) #15
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/36d8363c1cace489cbccfedcf3777863b12d4887
Cr-Commit-Position: refs/heads/master@{#28670}

Powered by Google App Engine
This is Rietveld 408576698