src/messages.h - Issue 1157563005: Do not eagerly convert exception to string when creating a message object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/messages.h

Issue 1157563005: Do not eagerly convert exception to string when creating a message object (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: small change Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/messages.h

diff --git a/src/messages.h b/src/messages.h

index 75314e93f989fcd9d041f9679d4607d2b625bd11..1b9d5c07c251d25a1813bc16e67ab667a6b0de24 100644

--- a/src/messages.h

+++ b/src/messages.h

@@ -436,7 +436,7 @@ class MessageHandler {

// Report a formatted message (needs JS allocation).

static void ReportMessage(Isolate* isolate, MessageLocation* loc,

- Handle<Object> message);

+ Handle<JSMessageObject> message);

static void DefaultMessageReport(Isolate* isolate, const MessageLocation* loc,

Handle<Object> message_obj);

« no previous file with comments | « src/isolate.cc ('k') | src/messages.cc » ('j') | no next file with comments »