Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: src/messages.h

Issue 1157563005: Do not eagerly convert exception to string when creating a message object (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: small change Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/isolate.cc ('k') | src/messages.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // The infrastructure used for (localized) message reporting in V8. 5 // The infrastructure used for (localized) message reporting in V8.
6 // 6 //
7 // Note: there's a big unresolved issue about ownership of the data 7 // Note: there's a big unresolved issue about ownership of the data
8 // structures used by this framework. 8 // structures used by this framework.
9 9
10 #ifndef V8_MESSAGES_H_ 10 #ifndef V8_MESSAGES_H_
(...skipping 418 matching lines...) Expand 10 before | Expand all | Expand 10 after
429 // of message listeners registered in an environment 429 // of message listeners registered in an environment
430 class MessageHandler { 430 class MessageHandler {
431 public: 431 public:
432 // Returns a message object for the API to use. 432 // Returns a message object for the API to use.
433 static Handle<JSMessageObject> MakeMessageObject( 433 static Handle<JSMessageObject> MakeMessageObject(
434 Isolate* isolate, MessageTemplate::Template type, MessageLocation* loc, 434 Isolate* isolate, MessageTemplate::Template type, MessageLocation* loc,
435 Handle<Object> argument, Handle<JSArray> stack_frames); 435 Handle<Object> argument, Handle<JSArray> stack_frames);
436 436
437 // Report a formatted message (needs JS allocation). 437 // Report a formatted message (needs JS allocation).
438 static void ReportMessage(Isolate* isolate, MessageLocation* loc, 438 static void ReportMessage(Isolate* isolate, MessageLocation* loc,
439 Handle<Object> message); 439 Handle<JSMessageObject> message);
440 440
441 static void DefaultMessageReport(Isolate* isolate, const MessageLocation* loc, 441 static void DefaultMessageReport(Isolate* isolate, const MessageLocation* loc,
442 Handle<Object> message_obj); 442 Handle<Object> message_obj);
443 static Handle<String> GetMessage(Isolate* isolate, Handle<Object> data); 443 static Handle<String> GetMessage(Isolate* isolate, Handle<Object> data);
444 static SmartArrayPointer<char> GetLocalizedMessage(Isolate* isolate, 444 static SmartArrayPointer<char> GetLocalizedMessage(Isolate* isolate,
445 Handle<Object> data); 445 Handle<Object> data);
446 }; 446 };
447 } } // namespace v8::internal 447 } } // namespace v8::internal
448 448
449 #endif // V8_MESSAGES_H_ 449 #endif // V8_MESSAGES_H_
OLDNEW
« no previous file with comments | « src/isolate.cc ('k') | src/messages.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698