Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1157543007: [arm64] fix incorrect hole-checking logic in full-codegen (Closed)

Created:
5 years, 6 months ago by caitp (gmail)
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm64] fix incorrect debug hole-checking logic in full-codegen BUG=v8:4159 LOG=N R=arv@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157543007/1
5 years, 6 months ago (2015-06-02 17:09:51 UTC) #2
commit-bot: I haz the power
Dry run: No LGTM from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 6 months ago (2015-06-02 17:09:54 UTC) #4
caitp (gmail)
On 2015/06/02 17:09:54, commit-bot: I haz the power wrote: > Dry run: No LGTM from ...
5 years, 6 months ago (2015-06-02 17:10:26 UTC) #5
Rodolph Perfetta (ARM)
lgtm
5 years, 6 months ago (2015-06-02 17:58:46 UTC) #7
caitp (gmail)
On 2015/06/02 17:58:46, Rodolph Perfetta (ARM) wrote: > lgtm This change doesn't solve the nosnap ...
5 years, 6 months ago (2015-06-02 19:30:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157543007/1
5 years, 6 months ago (2015-06-02 19:31:22 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 19:34:01 UTC) #12
Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/3125)

Powered by Google App Engine
This is Rietveld 408576698