Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Side by Side Diff: src/arm64/full-codegen-arm64.cc

Issue 1157543007: [arm64] fix incorrect hole-checking logic in full-codegen (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 2442 matching lines...) Expand 10 before | Expand all | Expand 10 after
2453 // jssp[8] : name. 2453 // jssp[8] : name.
2454 // jssp[16] : context. 2454 // jssp[16] : context.
2455 // jssp[24] : value. 2455 // jssp[24] : value.
2456 __ Push(x0, cp, x11, x10); 2456 __ Push(x0, cp, x11, x10);
2457 __ CallRuntime(Runtime::kStoreLookupSlot, 4); 2457 __ CallRuntime(Runtime::kStoreLookupSlot, 4);
2458 } else { 2458 } else {
2459 // Assignment to var or initializing assignment to let/const in harmony 2459 // Assignment to var or initializing assignment to let/const in harmony
2460 // mode. 2460 // mode.
2461 DCHECK(var->IsStackAllocated() || var->IsContextSlot()); 2461 DCHECK(var->IsStackAllocated() || var->IsContextSlot());
2462 MemOperand location = VarOperand(var, x1); 2462 MemOperand location = VarOperand(var, x1);
2463 if (FLAG_debug_code && op == Token::INIT_LET) { 2463 if (generate_debug_code_ && op == Token::INIT_LET) {
2464 __ Ldr(x10, location); 2464 __ Ldr(x10, location);
2465 __ CompareRoot(x10, Heap::kTheHoleValueRootIndex); 2465 __ CompareRoot(x10, Heap::kTheHoleValueRootIndex);
2466 __ Check(eq, kLetBindingReInitialization); 2466 __ Check(eq, kLetBindingReInitialization);
2467 } 2467 }
2468 EmitStoreToStackLocalOrContextSlot(var, location); 2468 EmitStoreToStackLocalOrContextSlot(var, location);
2469 } 2469 }
2470 2470
2471 } else if (op == Token::INIT_CONST_LEGACY) { 2471 } else if (op == Token::INIT_CONST_LEGACY) {
2472 // Const initializers need a write barrier. 2472 // Const initializers need a write barrier.
2473 DCHECK(var->mode() == CONST_LEGACY); 2473 DCHECK(var->mode() == CONST_LEGACY);
(...skipping 3064 matching lines...) Expand 10 before | Expand all | Expand 10 after
5538 } 5538 }
5539 5539
5540 return INTERRUPT; 5540 return INTERRUPT;
5541 } 5541 }
5542 5542
5543 5543
5544 } // namespace internal 5544 } // namespace internal
5545 } // namespace v8 5545 } // namespace v8
5546 5546
5547 #endif // V8_TARGET_ARCH_ARM64 5547 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698