src/arm64/full-codegen-arm64.cc - Issue 1157543007: [arm64] fix incorrect hole-checking logic in full-codegen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/full-codegen-arm64.cc

Issue 1157543007: [arm64] fix incorrect hole-checking logic in full-codegen (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm64/full-codegen-arm64.cc

diff --git a/src/arm64/full-codegen-arm64.cc b/src/arm64/full-codegen-arm64.cc

index dfbae7d59574814f5a9706f4fd686de00a62faba..5fb15d405cc7eb73b77b68bb6390bbf7c6095ce3 100644

--- a/src/arm64/full-codegen-arm64.cc

+++ b/src/arm64/full-codegen-arm64.cc

@@ -2460,7 +2460,7 @@ void FullCodeGenerator::EmitVariableAssignment(Variable* var, Token::Value op,

// mode.

DCHECK(var->IsStackAllocated() || var->IsContextSlot());

MemOperand location = VarOperand(var, x1);

- if (FLAG_debug_code && op == Token::INIT_LET) {

+ if (generate_debug_code_ && op == Token::INIT_LET) {

__ Ldr(x10, location);

__ CompareRoot(x10, Heap::kTheHoleValueRootIndex);

__ Check(eq, kLetBindingReInitialization);

« no previous file with comments | « no previous file | no next file » | no next file with comments »