Issue 11574032: Make unit testing of the compiler work with the new isolate helper library.

Issue 11574032: Make unit testing of the compiler work with the new isolate helper library. (Closed)

Created:
8 years ago by ngeoffray

Modified:
7 years, 11 months ago

Reviewers:
ahe, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Re-apply support for web workers and make unit testing of the compiler work with the new isolate helper library.

Patch Set 2 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+139 lines, -87 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	1	1 chunk	+2 lines, -23 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/foreign_helper.dart	View	1	2 chunks	+13 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart	View	1	20 chunks	+85 lines, -56 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_helper.dart	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1	2 chunks	+27 lines, -0 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
A +	tests/compiler/dart2js_extra/isolate2_negative_test.dart	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	tests/isolate/isolate.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/dom/templates/html/dart2js/html_dart2js.darttemplate	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/11574032/diff/2001/tests/compiler/dart2js/dart_backend_test.dart File tests/compiler/dart2js/dart_backend_test.dart (right): https://codereview.chromium.org/11574032/diff/2001/tests/compiler/dart2js/dart_backend_test.dart#newcode96 tests/compiler/dart2js/dart_backend_test.dart:96: if (uri.path.endsWith('/core.dart')) return new Future.immediate(coreLib); Maybe fix the ...

8 years ago (2012-12-14 10:13:42 UTC) #2

ahe

8 years ago (2012-12-14 10:13:52 UTC) #3

Test changes LGTM

https://codereview.chromium.org/11574032/diff/2001/tests/compiler/dart2js/dar...
File tests/compiler/dart2js/dart_backend_test.dart (right):

https://codereview.chromium.org/11574032/diff/2001/tests/compiler/dart2js/dar...
tests/compiler/dart2js/dart_backend_test.dart:102: if
(uri.path.endsWith('/isolate_helper.dart')) return new
Future.immediate(isolateHelperLib);
Long line.

https://codereview.chromium.org/11574032/diff/2001/tests/isolate/isolate2_neg...
File tests/isolate/isolate2_negative_test.dart (right):

https://codereview.chromium.org/11574032/diff/2001/tests/isolate/isolate2_neg...
tests/isolate/isolate2_negative_test.dart:21: port.receive((msg) {});
I would be more comfortable if this modification was made to a copy in
tests/compiler/dart2js.

Expand Messages | Collapse Messages