sdk/lib/_internal/compiler/implementation/lib/js_helper.dart - Issue 11574032: Make unit testing of the compiler work with the new isolate helper library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/js_helper.dart

Issue 11574032: Make unit testing of the compiler work with the new isolate helper library. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/lib/js_helper.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/lib/js_helper.dart (revision 16793)

+++ sdk/lib/_internal/compiler/implementation/lib/js_helper.dart (working copy)

@@ -1145,13 +1145,18 @@

if (closure == null) return null;

var function = JS('var', r'#.$identity', closure);

if (JS('bool', r'!!#', function)) return function;

+ // Fetch the current isolate in a local variable to prevent the

+ // compiler from inlining its use in the following JS expression:

+ // the current isolate may have changed so if we read it from the JS

+ // closure, it leads to the wrong isolate.

+ var currentIsolate = JS_CURRENT_ISOLATE();

function = JS("var", r"""function() {

return #(#, #, #, arguments[0], arguments[1]);

}""",

DART_CLOSURE_TO_JS(invokeClosure),

closure,

- JS_CURRENT_ISOLATE(),

+ currentIsolate,

arity);

JS('void', r'#.$identity = #', closure, function);