Intel VTune integration for V8/D8

build/common.gypi

Index: build/common.gypi
===================================================================
--- build/common.gypi	(revision 13219)
+++ build/common.gypi	(working copy)
@@ -74,6 +74,8 @@
 
     'v8_object_print%': 0,
 
+    'v8_enable_vtunejit%': 0,

[Jakob Kummerow, 2012/12/21 12:50:59]

A short comment would be nice, e.g.:
# Enable support for Intel VTune. Supported on ia32/x64 only.

+
     # Enable profiling support. Only required on Windows.
     'v8_enable_prof%': 0,
 
@@ -89,6 +91,7 @@
     'v8_use_snapshot%': 'true',
     'host_os%': '<(OS)',
     'v8_use_liveobjectlist%': 'false',
+    #'werror%': '',

[Jakob Kummerow, 2012/12/21 12:50:59]

what's this?

     'werror%': '-Werror',
 
     # With post mortem support enabled, metadata is embedded into libv8 that
@@ -123,6 +126,15 @@
       ['v8_interpreted_regexp==1', {
         'defines': ['V8_INTERPRETED_REGEXP',],
       }],
+      ['v8_enable_vtunejit==1', {
+       'conditions': [

[Jakob Kummerow, 2012/12/21 12:50:59]

nit: indentation

+         ['v8_target_arch=="ia32" or v8_target_arch=="x64"', {

[Jakob Kummerow, 2012/12/21 12:50:59]

A 'conditions' section inside a 'conditions' section? You can just combine the
conditions:

      ['v8_enable_vtunejit==1 and \
          (v8_target_arch=="ia32" or v8_target_arch=="x64")', {
        'defines': ...

On the other hand, the define and the libary don't hurt for other target archs,
right? Since v8_enable_vtunejit defaults to 0, you could just skip the
v8_target_arch condition, and leave it up to the user to realize that VTune
doesn't support non-Intel architectures.

+           'defines': ['ENABLE_VTUNE_JIT_INTERFACE',],
+           'libraries': ['-ldl',],
+#dw -ljitprofiling',],

[Jakob Kummerow, 2012/12/21 12:50:59]

what's this?

+         }],
+        ],
+      }],
       ['v8_target_arch=="arm"', {
         'defines': [
           'V8_TARGET_ARCH_ARM',