Intel VTune integration for V8/D8

build/common.gypi

 # Copyright 2012 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
 #       disclaimer in the documentation and/or other materials provided
@@ skipping 56 matching lines @@
     'mips_arch_variant%': 'mips32r2',
 
     'v8_enable_debugger_support%': 1,
 
     'v8_enable_disassembler%': 0,
 
     'v8_enable_gdbjit%': 0,
 
     'v8_object_print%': 0,
 
+    'v8_enable_vtunejit%': 0,

[Jakob Kummerow, 2012/12/21 12:50:59]

A short comment would be nice, e.g.:
# Enable support for Intel VTune. Supported on ia32/x64 only.

+
     # Enable profiling support. Only required on Windows.
     'v8_enable_prof%': 0,
 
     'v8_enable_verify_heap%': 0,
 
     # Some versions of GCC 4.5 seem to need -fno-strict-aliasing.
     'v8_no_strict_aliasing%': 0,
 
     # Chrome needs this definition unconditionally. For standalone V8 builds,
     # it's handled in build/standalone.gypi.
     'want_separate_host_toolset%': 1,
 
     'v8_use_snapshot%': 'true',
     'host_os%': '<(OS)',
     'v8_use_liveobjectlist%': 'false',
+    #'werror%': '',

[Jakob Kummerow, 2012/12/21 12:50:59]

what's this?

     'werror%': '-Werror',
 
     # With post mortem support enabled, metadata is embedded into libv8 that
     # describes various parameters of the VM for use by debuggers. See
     # tools/gen-postmortem-metadata.py for details.
     'v8_postmortem_support%': 'false',
 
     # For a shared library build, results in "libv8-<(soname_version).so".
     'soname_version%': '',
 
@@ skipping 14 matching lines @@
       }],
       ['v8_object_print==1', {
         'defines': ['OBJECT_PRINT',],
       }],
       ['v8_enable_verify_heap==1', {
         'defines': ['VERIFY_HEAP',],
       }],
       ['v8_interpreted_regexp==1', {
         'defines': ['V8_INTERPRETED_REGEXP',],
       }],
+      ['v8_enable_vtunejit==1', {
+       'conditions': [

[Jakob Kummerow, 2012/12/21 12:50:59]

nit: indentation

+         ['v8_target_arch=="ia32" or v8_target_arch=="x64"', {

[Jakob Kummerow, 2012/12/21 12:50:59]

A 'conditions' section inside a 'conditions' section? You can just combine the
conditions:

      ['v8_enable_vtunejit==1 and \
          (v8_target_arch=="ia32" or v8_target_arch=="x64")', {
        'defines': ...

On the other hand, the define and the libary don't hurt for other target archs,
right? Since v8_enable_vtunejit defaults to 0, you could just skip the
v8_target_arch condition, and leave it up to the user to realize that VTune
doesn't support non-Intel architectures.

+           'defines': ['ENABLE_VTUNE_JIT_INTERFACE',],
+           'libraries': ['-ldl',],
+#dw -ljitprofiling',],

[Jakob Kummerow, 2012/12/21 12:50:59]

what's this?

+         }],
+        ],
+      }],
       ['v8_target_arch=="arm"', {
         'defines': [
           'V8_TARGET_ARCH_ARM',
         ],
         'conditions': [
           ['armv7==1', {
             'defines': [
               'CAN_USE_ARMV7_INSTRUCTIONS=1',
             ],
           }],
@@ skipping 317 matching lines @@
                 'OptimizeReferences': '2',
                 'EnableCOMDATFolding': '2',
               },
             },
           }],  # OS=="win"
         ],  # conditions
       },  # Release
     },  # configurations
   },  # target_defaults
 }