Intel VTune integration for V8/D8

src/v8.cc

Index: src/v8.cc
===================================================================
--- src/v8.cc	(revision 13219)
+++ src/v8.cc	(working copy)
@@ -45,6 +45,10 @@
 #include "serialize.h"
 #include "store-buffer.h"
 
+#ifdef ENABLE_VTUNE_JIT_INTERFACE
+#include "third_party/vtune/vtune-jit.h"
+#endif
+
 namespace v8 {
 namespace internal {
 
@@ -82,7 +86,10 @@
          i::Isolate::Current());
 
   if (IsDead()) return false;
-
+#ifdef ENABLE_VTUNE_JIT_INTERFACE
+  if (i::FLAG_jit_profile)

[danno, 2012/12/20 16:34:38]

My primary feedback about this patch is that the enabling of VTune profiling
should be a decision for the embedder, i.e. D8 or Chromium. You might want to
include a utility file in the vtune directory that calls V8::Initialize and then
immediately afterwards "v8::V8::SetJitCodeEventHandler(v8::kJitCodeEventDefault,
i::VTUNEJITInterface::event_handler);" You can then move the initialization to
D8 with the appropriate build flags. You will have to provide a patch to
Chromium, too.

+     v8::V8::SetJitCodeEventHandler(v8::kJitCodeEventDefault, i::VTUNEJITInterface::event_handler);
+#endif
   Isolate* isolate = Isolate::Current();
   if (isolate->IsInitialized()) return true;