Intel VTune integration for V8/D8

src/v8.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 27 matching lines @@
 #include "hydrogen.h"
 #include "lithium-allocator.h"
 #include "log.h"
 #include "objects.h"
 #include "once.h"
 #include "platform.h"
 #include "runtime-profiler.h"
 #include "serialize.h"
 #include "store-buffer.h"
 
+#ifdef ENABLE_VTUNE_JIT_INTERFACE
+#include "third_party/vtune/vtune-jit.h"
+#endif
+
 namespace v8 {
 namespace internal {
 
 V8_DECLARE_ONCE(init_once);
 
 bool V8::is_running_ = false;
 bool V8::has_been_set_up_ = false;
 bool V8::has_been_disposed_ = false;
 bool V8::has_fatal_error_ = false;
 bool V8::use_crankshaft_ = true;
@@ skipping 17 matching lines @@
     i::Isolate::EnterDefaultIsolate();
   }
 
   ASSERT(i::Isolate::CurrentPerIsolateThreadData() != NULL);
   ASSERT(i::Isolate::CurrentPerIsolateThreadData()->thread_id().Equals(
            i::ThreadId::Current()));
   ASSERT(i::Isolate::CurrentPerIsolateThreadData()->isolate() ==
          i::Isolate::Current());
 
   if (IsDead()) return false;
-
+#ifdef ENABLE_VTUNE_JIT_INTERFACE
+  if (i::FLAG_jit_profile)

[danno, 2012/12/20 16:34:38]

My primary feedback about this patch is that the enabling of VTune profiling
should be a decision for the embedder, i.e. D8 or Chromium. You might want to
include a utility file in the vtune directory that calls V8::Initialize and then
immediately afterwards "v8::V8::SetJitCodeEventHandler(v8::kJitCodeEventDefault,
i::VTUNEJITInterface::event_handler);" You can then move the initialization to
D8 with the appropriate build flags. You will have to provide a patch to
Chromium, too.

+     v8::V8::SetJitCodeEventHandler(v8::kJitCodeEventDefault, i::VTUNEJITInterface::event_handler);
+#endif
   Isolate* isolate = Isolate::Current();
   if (isolate->IsInitialized()) return true;
 
   is_running_ = true;
   has_been_set_up_ = true;
   has_fatal_error_ = false;
   has_been_disposed_ = false;
 
   return isolate->Init(des);
 }
@@ skipping 196 matching lines @@
   SetUpJSCallerSavedCodeData();
   SamplerRegistry::SetUp();
   ExternalReference::SetUp();
 }
 
 void V8::InitializeOncePerProcess() {
   CallOnce(&init_once, &InitializeOncePerProcessImpl);
 }
 
 } }  // namespace v8::internal