Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Issue 11574023: Ignore GL_ANGLE_framebuffer_multisample on Android. (Closed)

Created:
8 years ago by aelias_OOO_until_Jul13
Modified:
8 years ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, darin-cc_chromium.org, apatrick_chromium, no sievers, klobag
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Ignore GL_ANGLE_framebuffer_multisample on Android. For some reason, some Qualcomm drivers add this string to their extensions list, but don't support glRenderbufferStorageMultisampleEXT(). This works around the issue. BUG=165736 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173117

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M gpu/command_buffer/service/feature_info.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
aelias_OOO_until_Jul13
Hi apatrick, I don't know why this ANGLE string somehow ended up in an Android ...
8 years ago (2012-12-14 00:50:24 UTC) #1
apatrick_chromium
Wat! LGTM.
8 years ago (2012-12-14 01:06:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/11574023/1
8 years ago (2012-12-14 01:12:06 UTC) #3
commit-bot: I haz the power
8 years ago (2012-12-14 07:24:55 UTC) #4
Message was sent while issue was closed.
Change committed as 173117

Powered by Google App Engine
This is Rietveld 408576698