[net/http auth] Use strings to identify authentication schemes.

net/http/http_auth_handler_basic.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_auth_handler_basic.h"
 
 #include <string>
 
 #include "base/base64.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "net/base/net_errors.h"
 #include "net/base/net_string_util.h"
 #include "net/http/http_auth.h"
 #include "net/http/http_auth_challenge_tokenizer.h"
 
 namespace net {
 
 namespace {
 
+const char* const kBasicSchemeName = "basic";
+
 // Parses a realm from an auth challenge, and converts to UTF8-encoding.
 // Returns whether the realm is invalid or the parameters are invalid.
 //
 // Note that if a realm was not specified, we will default it to "";
 // so specifying 'Basic realm=""' is equivalent to 'Basic'.
 //
 // This is more generous than RFC 2617, which is pretty clear in the
 // production of challenge that realm is required.
 //
 // We allow it to be compatibility with certain embedded webservers that don't
@@ skipping 15 matching lines @@
     if (!ConvertToUtf8AndNormalize(parameters.value(), kCharsetLatin1, realm)) {
       return false;
     }
   }
   return parameters.valid();
 }
 
 }  // namespace
 
 bool HttpAuthHandlerBasic::Init(HttpAuthChallengeTokenizer* challenge) {
-  auth_scheme_ = HttpAuth::AUTH_SCHEME_BASIC;
-  score_ = 1;
-  properties_ = 0;
+  auth_scheme_ = kBasicSchemeName;
   return ParseChallenge(challenge);
 }
 
 bool HttpAuthHandlerBasic::ParseChallenge(
     HttpAuthChallengeTokenizer* challenge) {
   // Verify the challenge's auth-scheme.
-  if (!base::LowerCaseEqualsASCII(challenge->scheme(), "basic"))
+  if (!challenge->SchemeIs(kBasicSchemeName))
     return false;
 
   std::string realm;
   if (!ParseRealm(*challenge, &realm))
     return false;
 
   realm_ = realm;
   return true;
 }
 
@@ skipping 40 matching lines @@
   // TODO(cbentzel): Move towards model of parsing in the factory
   //                 method and only constructing when valid.
   scoped_ptr<HttpAuthHandler> tmp_handler(new HttpAuthHandlerBasic());
   if (!tmp_handler->InitFromChallenge(challenge, target, origin, net_log))
     return ERR_INVALID_RESPONSE;
   handler->swap(tmp_handler);
   return OK;
 }
 
 }  // namespace net