net/http/http_log_util.cc - Issue 1157333005: [net/http auth] Use strings to identify authentication schemes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_log_util.cc

Issue 1157333005: [net/http auth] Use strings to identify authentication schemes. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_log_util.cc

diff --git a/net/http/http_log_util.cc b/net/http/http_log_util.cc

index 87c2fd99f191cf2c11443611bd6db6d90000686b..8bd864edc405c5250b2873a22853f65f129b1a8a 100644

--- a/net/http/http_log_util.cc

+++ b/net/http/http_log_util.cc

@@ -19,7 +19,7 @@ bool ShouldRedactChallenge(HttpAuthChallengeTokenizer* challenge) {

if (challenge->challenge_text().find(',') != std::string::npos)

return false;

- std::string scheme = base::ToLowerASCII(challenge->scheme());

+ std::string scheme = challenge->NormalizedScheme();

// Invalid input.

if (scheme.empty())

return false;

« no previous file with comments | « net/http/http_auth_unittest.cc ('k') | net/http/http_network_transaction_unittest.cc » ('j') | no next file with comments »