Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1157273006: Fix the System Profile to not load extensions. It could otherwise be forced to by GPO. (Closed)

Created:
5 years, 7 months ago by Mike Lerman
Modified:
5 years, 7 months ago
Reviewers:
msw
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, rginda+watch_chromium.org, asvitkine+watch_chromium.org, kalyank, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2403
Target Ref:
refs/pending/branch-heads/2403
Project:
chromium
Visibility:
Public.

Description

Fix the System Profile to not load extensions. It could otherwise be forced to by GPO. A few releases ago I introduced a System Profile to back the User Manager (https://codereview.chromium.org/847733005). This profile, however, is causing some problems. I'm trying to reduce those by making clearer the contract of what it's for: A profile that doesn't take a browser window, has no extensions, writes little to disk, etc. This certainly addresses issue #4 raised within the bug, and address the other issues as well (I can't repro them). This CL generally hardens Chrome for the System Profile in a lot of the same ways we do the Guest Profile. BUG=482176 TBR=msw@chromium.org Review URL: https://codereview.chromium.org/1129293002 Cr-Commit-Position: refs/heads/master@{#331276} (cherry picked from commit 7831f57d5f56e9cafe77388b20a83a90d6eb7918) Committed: https://chromium.googlesource.com/chromium/src/+/a515307f37fd3c6b7d20a2f93e4654b4f76ab991

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -35 lines) Patch
M chrome/browser/app_controller_mac.mm View 2 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/extensions/chrome_process_manager_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_system_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/tab_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profiles/profile_manager.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 6 chunks +14 lines, -12 lines 0 comments Download
M chrome/browser/profiles/profile_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/test/base/testing_profile_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/actions/actions.xml View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Mike Lerman
5 years, 7 months ago (2015-05-27 18:56:53 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a515307f37fd3c6b7d20a2f93e4654b4f76ab991 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698