chrome/browser/ui/browser.cc - Issue 1157273006: Fix the System Profile to not load extensions. It could otherwise be forced to by GPO.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.cc

Issue 1157273006: Fix the System Profile to not load extensions. It could otherwise be forced to by GPO. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2403

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc ('k') | chrome/browser/ui/browser_command_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser.cc

diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc

index c1556d9e1bb6c69324779bc9d7c71a1975e8835d..d094a593eb45e10a260dd9213d72e12d4cd9a22d 100644

--- a/chrome/browser/ui/browser.cc

+++ b/chrome/browser/ui/browser.cc

@@ -365,6 +365,12 @@ Browser::Browser(const CreateParams& params)

CHECK(IncognitoModePrefs::CanOpenBrowser(profile_));

CHECK(!profile_->IsGuestSession() || profile_->IsOffTheRecord())

<< "Only off the record browser may be opened in guest mode";

+ DCHECK(!profile_->IsSystemProfile())

+ << "The system profile should never have a real browser.";

+ // TODO(mlerman): After this hits stable channel, see if there are counts

+ // for this metric. If not, change the DCHECK above to a CHECK.

+ if (profile_->IsSystemProfile())

+ content::RecordAction(base::UserMetricsAction("BrowserForSystemProfile"));

// TODO(jeremy): Move to initializer list once flag is removed.

if (IsFastTabUnloadEnabled())

« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc ('k') | chrome/browser/ui/browser_command_controller.cc » ('j') | no next file with comments »