Move User Manager onto a System profile.

Move User Manager onto a System profile.

There are issue with the Guest Profile's cookies not being cleared as they should be when Guest Mode is closed. To ensure the Guest Profile isn't being used when there are no Guest browsers open, move the User Manager onto a new profile.

This is a modern version of this older CL: https://codereview.chromium.org/239543012/

BUG=445036
Committed: https://crrev.com/b8df6e822aa311ecc63fd58544ea595ab4eb2c40
Cr-Commit-Position: refs/heads/master@{#312906}

[Mike Lerman, 2015-01-15 18:04:58]

mlerman@chromium.org changed reviewers:
+ noms@chromium.org, thakis@chromium.org

[Mike Lerman, 2015-01-15 18:04:58]

Wondering and well-wishing reviewers,

Could I request your attention at this CL?

noms@ - profiles and overall
thakis@ - everything but profiles

Thanks!

[noms (inactive), 2015-01-20 13:43:17]

https://codereview.chromium.org/847733005/diff/80001/chrome/browser/profiles/...
File chrome/browser/profiles/profile.h (right):

https://codereview.chromium.org/847733005/diff/80001/chrome/browser/profiles/...
chrome/browser/profiles/profile.h:322: // Returns whether it is a guest session.
nit: Bleh, not a giant fan about how one is a guest "session", but the other is
a system "profile". Seems inconsistent.

https://codereview.chromium.org/847733005/diff/80001/chrome/browser/profiles/...
chrome/browser/profiles/profile.h:409: bool is_system_profile_;
Please document what a system profile means, and when it should be used.

[Mike Lerman, 2015-01-20 16:18:11]

https://codereview.chromium.org/847733005/diff/80001/chrome/browser/profiles/...
File chrome/browser/profiles/profile.h (right):

https://codereview.chromium.org/847733005/diff/80001/chrome/browser/profiles/...
chrome/browser/profiles/profile.h:322: // Returns whether it is a guest session.
On 2015/01/20 13:43:17, Monica Dinculescu wrote:
> nit: Bleh, not a giant fan about how one is a guest "session", but the other
is
> a system "profile". Seems inconsistent.

Dy'arg, ok, I'll fix that in another CL. IsGuestSession() -> IsGuestProfile().

https://codereview.chromium.org/847733005/diff/80001/chrome/browser/profiles/...
chrome/browser/profiles/profile.h:409: bool is_system_profile_;
On 2015/01/20 13:43:17, Monica Dinculescu wrote:
> Please document what a system profile means, and when it should be used.

Done.

[noms (inactive), 2015-01-23 01:03:51]

lgtm!

https://codereview.chromium.org/847733005/diff/100001/chrome/test/base/testin...
File chrome/test/base/testing_profile_manager.cc (right):

https://codereview.chromium.org/847733005/diff/100001/chrome/test/base/testin...
chrome/test/base/testing_profile_manager.cc:147: // Add the guest profile to the
profile manager, but not to the info cache.
nit: s/guest/system

[Mike Lerman, 2015-01-23 17:42:27]

Nico, over to you for the non-Profiles bits. Thanks!

Thanks, Monica!

https://codereview.chromium.org/847733005/diff/100001/chrome/test/base/testin...
File chrome/test/base/testing_profile_manager.cc (right):

https://codereview.chromium.org/847733005/diff/100001/chrome/test/base/testin...
chrome/test/base/testing_profile_manager.cc:147: // Add the guest profile to the
profile manager, but not to the info cache.
On 2015/01/23 01:03:51, Monica Dinculescu wrote:
> nit: s/guest/system

Done.

[Nico, 2015-01-23 18:08:09]

"system profile" is a new invention in this patch, not an existing thing, right?
I think chromeos also has a "system profile", but if the profile/OWNERS (in this
case, noms) are happy with this name I suppose it's cool.

The non-profile bits of this CL look fine to me, but given the linked bug, I
would've expected a test that opens a guest profile, sets a cookie, closes it,
opens it, checks that the cookie is gone (or some moral equivalent thereof).

[Mike Lerman, 2015-01-23 18:23:03]

Noms and I chatted about the name, and settled on this. Yes, it's a new
invention, here :)

This is not the last CL for the linked bug... I have another CL (started here:
https://codereview.chromium.org/853743002/) which is dependent on this one, that
will close the bug. This CL is just a stepping stone to a greater goal.

[Nico, 2015-01-23 18:26:26]

On 2015/01/23 18:23:03, Mike Lerman wrote:
> Noms and I chatted about the name, and settled on this. Yes, it's a new
> invention, here :)

I'm fine with whatever name you settle on. Maybe give it one last, final chat
:-)

> This is not the last CL for the linked bug... I have another CL (started here:
> https://codereview.chromium.org/853743002/) which is dependent on this one,
that
> will close the bug. This CL is just a stepping stone to a greater goal.

lgtm, definitely don't want to be in the way of a greater goal. (assuming the
greater goal includes a test at the end.)

[Mike Lerman, 2015-01-23 18:36:36]

The CQ bit was checked by mlerman@chromium.org

[commit-bot: I haz the power, 2015-01-23 18:38:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/847733005/140001

[commit-bot: I haz the power, 2015-01-23 19:56:15]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-01-23 19:57:39]

Patchset 8 (id:??) landed as
https://crrev.com/b8df6e822aa311ecc63fd58544ea595ab4eb2c40
Cr-Commit-Position: refs/heads/master@{#312906}