Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 11571004: Implement is-checks for static functions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
diff --git a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
index bf500a8d468b44f1cd5143dbe50f3da6293e0e07..c6656510102dcf53c1c2d86bce88adffc431865f 100644
--- a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
+++ b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
@@ -2398,6 +2398,9 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
|| Elements.isListSupertype(element, compiler)) {
handleListOrSupertypeCheck(input, type);
attachLocationToLast(node);
+ } else if (element.isTypedef()) {
ngeoffray 2012/12/13 12:38:57 Why did you need this? Code can just fall through.
karlklose 2012/12/13 13:08:46 It falls down to the next case which emits and obj
ngeoffray 2012/12/13 13:20:37 I see. So don't you need to also check for null he
karlklose 2012/12/13 14:10:48 Indeed, done.
+ checkType(input, type);
+ attachLocationToLast(node);
} else if (types[input].canBePrimitive() || types[input].canBeNull()) {
checkObject(input, '===');
js.Expression objectTest = pop();

Powered by Google App Engine
This is Rietveld 408576698