Implement is-checks for static functions.

Implement is-checks for static functions.

BUG=dartbug.com/5022

[ngeoffray, 2012-12-13 12:38:57]

https://codereview.chromium.org/11571004/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right):

https://codereview.chromium.org/11571004/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1254: for
(TypedefElement typedef in checkedTypedefs) {
This will add is checks to all static functions. You only need them for static
functions that are closurized. So this code should be in
Emitter::emitStaticFunctionGetters.

https://codereview.chromium.org/11571004/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right):

https://codereview.chromium.org/11571004/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:2401: } else if
(element.isTypedef()) {
Why did you need this? Code can just fall through. Also, with this change, "null
is Typedef" would fail. Is that not covered by tests?

[karlklose, 2012-12-13 13:08:46]

https://codereview.chromium.org/11571004/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right):

https://codereview.chromium.org/11571004/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1254: for
(TypedefElement typedef in checkedTypedefs) {
On 2012/12/13 12:38:57, ngeoffray wrote:
> This will add is checks to all static functions. You only need them for static
> functions that are closurized. So this code should be in
> Emitter::emitStaticFunctionGetters.

Done.

https://codereview.chromium.org/11571004/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right):

https://codereview.chromium.org/11571004/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:2401: } else if
(element.isTypedef()) {
It falls down to the next case which emits and object check, but the value is
actually a function.

[ngeoffray, 2012-12-13 13:20:36]

https://codereview.chromium.org/11571004/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right):

https://codereview.chromium.org/11571004/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:2401: } else if
(element.isTypedef()) {
On 2012/12/13 13:08:46, karlklose wrote:
> It falls down to the next case which emits and object check, but the value is
> actually a function.

I see. So don't you need to also check for null here?

https://codereview.chromium.org/11571004/diff/4001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right):

https://codereview.chromium.org/11571004/diff/4001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1300: if
(compiler.types.isSubtype(element.computeType(compiler),
move element.computeType out of the loop.

https://codereview.chromium.org/11571004/diff/4001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1303:
buffer.add('$fieldAccess.is\$$typedefName$_=${_}true$N');
Please use namer.operatorIs.

[karlklose, 2012-12-13 14:10:48]

https://codereview.chromium.org/11571004/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right):

https://codereview.chromium.org/11571004/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:2401: } else if
(element.isTypedef()) {
Indeed, done.

[ngeoffray, 2012-12-14 09:02:19]

I have submitted this CL in: https://codereview.chromium.org/11572009/