Implement is-checks for static functions.

sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 class SsaCodeGeneratorTask extends CompilerTask {
 
   final JavaScriptBackend backend;
 
@@ skipping 2380 matching lines @@
     } else if (Elements.isNumberOrStringSupertype(element, compiler)) {
       handleNumberOrStringSupertypeCheck(input, type);
       attachLocationToLast(node);
     } else if (Elements.isStringOnlySupertype(element, compiler)) {
       handleStringSupertypeCheck(input, type);
       attachLocationToLast(node);
     } else if (identical(element, compiler.listClass)
                || Elements.isListSupertype(element, compiler)) {
       handleListOrSupertypeCheck(input, type);
       attachLocationToLast(node);
+    } else if (element.isTypedef()) {

[ngeoffray, 2012/12/13 12:38:57]

Why did you need this? Code can just fall through. Also, with this change, "null
is Typedef" would fail. Is that not covered by tests?

[karlklose, 2012/12/13 13:08:46]

It falls down to the next case which emits and object check, but the value is
actually a function.

[ngeoffray, 2012/12/13 13:20:37]

I see. So don't you need to also check for null here?

[karlklose, 2012/12/13 14:10:48]

Indeed, done.

+      checkType(input, type);
+      attachLocationToLast(node);
     } else if (types[input].canBePrimitive() || types[input].canBeNull()) {
       checkObject(input, '===');
       js.Expression objectTest = pop();
       checkType(input, type);
       push(new js.Binary('&&', objectTest, pop()), node);
     } else {
       checkType(input, type);
       attachLocationToLast(node);
     }
     if (node.hasArgumentChecks()) {
@@ skipping 639 matching lines @@
   if (leftType.canBeNull() && rightType.canBeNull()) {
     if (left.isConstantNull() || right.isConstantNull() ||
         (leftType.isPrimitive() && leftType == rightType)) {
       return '==';
     }
     return null;
   } else {
     return '===';
   }
 }