Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 1157023002: [turbofan] Change End to take a variable number of inputs. (Closed)

Created:
5 years, 7 months ago by Benedikt Meurer
Modified:
5 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Change End to take a variable number of inputs. This simplifies the handling of the End node. Based on this CL we will finally fix terminating every loop from the beginning (via Terminate nodes) and fix inlining of Throw, Deoptimize and Terminate. R=mstarzinger@chromium.org Committed: https://crrev.com/2b93b8aa4175e4fb12d93e09c59e12867d6b030c Cr-Commit-Position: refs/heads/master@{#28620}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -175 lines) Patch
M src/compiler/ast-graph-builder.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M src/compiler/common-operator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/common-operator.cc View 4 chunks +43 lines, -1 line 0 comments Download
M src/compiler/control-reducer.cc View 3 chunks +32 lines, -16 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +28 lines, -42 lines 2 comments Download
M src/compiler/node-properties.cc View 1 chunk +2 lines, -10 lines 0 comments Download
M src/compiler/osr.cc View 1 chunk +7 lines, -12 lines 0 comments Download
M test/cctest/compiler/simplified-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-control-reducer.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/compiler/test-js-constant-cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-js-context-specialization.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-loop-analysis.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-osr.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-run-stubs.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/common-operator-unittest.cc View 3 chunks +19 lines, -1 line 0 comments Download
M test/unittests/compiler/control-equivalence-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/control-flow-optimizer-unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/unittests/compiler/control-reducer-unittest.cc View 4 chunks +12 lines, -16 lines 0 comments Download
M test/unittests/compiler/graph-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/js-type-feedback-unittest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +3 lines, -1 line 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +9 lines, -2 lines 0 comments Download
M test/unittests/compiler/scheduler-unittest.cc View 20 chunks +20 lines, -21 lines 0 comments Download
M test/unittests/compiler/tail-call-optimization-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Benedikt Meurer
5 years, 7 months ago (2015-05-26 09:29:25 UTC) #1
Benedikt Meurer
Hey Michi, Make End nice. :-) Please take a look. Thanks, Benedikt
5 years, 7 months ago (2015-05-26 09:29:59 UTC) #2
Michael Starzinger
LGTM. https://codereview.chromium.org/1157023002/diff/1/src/compiler/js-inlining.cc File src/compiler/js-inlining.cc (right): https://codereview.chromium.org/1157023002/diff/1/src/compiler/js-inlining.cc#newcode189 src/compiler/js-inlining.cc:189: jsgraph_->common()->Merge(input_count), input_count, &controls.front()); This will create a singleton ...
5 years, 7 months ago (2015-05-26 10:28:05 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/1157023002/diff/1/src/compiler/js-inlining.cc File src/compiler/js-inlining.cc (right): https://codereview.chromium.org/1157023002/diff/1/src/compiler/js-inlining.cc#newcode189 src/compiler/js-inlining.cc:189: jsgraph_->common()->Merge(input_count), input_count, &controls.front()); Yes. My plan is to optimize ...
5 years, 7 months ago (2015-05-26 10:29:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157023002/1
5 years, 7 months ago (2015-05-26 10:29:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-26 10:32:01 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 10:32:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b93b8aa4175e4fb12d93e09c59e12867d6b030c
Cr-Commit-Position: refs/heads/master@{#28620}

Powered by Google App Engine
This is Rietveld 408576698