Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 11568029: Add a command to lose the context (Closed)

Created:
8 years ago by greggman
Modified:
8 years ago
CC:
chromium-reviews, apatrick_chromium, Ken Russell (switch to Gerrit)
Visibility:
Public.

Description

Add a command to lose the context BUG=166020 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173441

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : add docs, lose parent and children, fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+411 lines, -40 lines) Patch
A gpu/GLES2/extensions/CHROMIUM/CHROMIUM_lose_context.txt View 1 2 3 1 chunk +55 lines, -0 lines 0 comments Download
M gpu/GLES2/gl2chromium.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 3 chunks +16 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 1 1 chunk +38 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 1 chunk +15 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_autogen.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/context_group.h View 1 5 chunks +13 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/context_group.cc View 1 4 chunks +37 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/context_group_unittest.cc View 1 8 chunks +10 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 5 chunks +47 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_3_autogen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 3 chunks +8 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_autogen.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
A gpu/command_buffer/tests/gl_lose_context_chromium_unittests.cc View 1 1 chunk +63 lines, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 1 3 chunks +9 lines, -3 lines 0 comments Download
M gpu/command_buffer/tests/gl_test_utils.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_test_utils.cc View 1 2 chunks +6 lines, -1 line 0 comments Download
M gpu/gpu.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/khronos/GLES2/gl2ext.h View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/khronos/README.chromium View 1 2 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
greggman
As the comment in gles2_cmd_decoder.cc says this probably needs to do either 1) lose the ...
8 years ago (2012-12-14 05:32:50 UTC) #1
jamesr
(1) would be more useful for the compositor.
8 years ago (2012-12-14 18:02:41 UTC) #2
apatrick_chromium
LGTM. I think it might be useful to be able to specify the nature of ...
8 years ago (2012-12-14 19:27:03 UTC) #3
Ken Russell (switch to Gerrit)
Thanks for implementing this. A couple of thoughts. https://codereview.chromium.org/11568029/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/11568029/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode3351 gpu/command_buffer/service/gles2_cmd_decoder.cc:3351: // ...
8 years ago (2012-12-15 01:21:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/11568029/19003
8 years ago (2012-12-17 06:50:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/11568029/24004
8 years ago (2012-12-17 07:21:06 UTC) #6
commit-bot: I haz the power
8 years ago (2012-12-17 10:19:11 UTC) #7
Message was sent while issue was closed.
Change committed as 173441

Powered by Google App Engine
This is Rietveld 408576698