Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(13)

Issue 11568021: Merge 169553 (Closed)

Created:
6 years, 5 months ago by DaleCurtis
Modified:
6 years, 5 months ago
Reviewers:
Dale Curtis
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Merge 169553 > Always wait for DataReady() on Windows WaveOut. > > Only WaveOut still needs this hack and since all renderer clients > now use the shared memory marker we can always wait for it. > > I suspect on low end machines this timeout is leading to pops and > clicks for some users on XP. > > BUG=161307 > TEST=audio still works. > > Review URL: https://codereview.chromium.org/11348166 TBR=dalecurtis@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172979

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -48 lines) Patch
M content/browser/renderer_host/media/audio_sync_reader.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_sync_reader.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M media/audio/audio_io.h View 1 chunk +4 lines, -8 lines 0 comments Download
M media/audio/audio_output_controller.h View 1 chunk +1 line, -5 lines 0 comments Download
M media/audio/audio_output_controller.cc View 2 chunks +15 lines, -10 lines 0 comments Download
M media/audio/audio_output_resampler.cc View 6 chunks +26 lines, -2 lines 0 comments Download
M media/audio/win/waveout_output_win.cc View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
DaleCurtis
6 years, 5 months ago (2012-12-13 21:52:55 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698