Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1156713003: Subzero ARM: lower alloca instruction. (Closed)

Created:
5 years, 7 months ago by jvoung (off chromium)
Modified:
5 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero ARM: lower alloca instruction. Lower alloca in a way similar to x86. Subtract the stack and align if needed, then copy that stack address to dest. Sometimes use "bic" for the mask, sometimes use "and", depending on what fits better. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4076 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=55500dbceb14d4223533701158389e89c1f93a5e

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : one more test case #

Patch Set 4 : restore comment and sprinkle more #

Total comments: 4

Patch Set 5 : review #

Patch Set 6 : trailing space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -21 lines) Patch
M src/IceInstARM32.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/IceInstARM32.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/IceTargetLoweringARM32.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M src/IceTargetLoweringARM32.cpp View 1 2 3 4 3 chunks +56 lines, -2 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 1 2 3 4 5 chunks +8 lines, -16 lines 0 comments Download
M src/IceUtils.h View 1 2 3 3 chunks +13 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/alloc.ll View 1 2 3 4 5 8 chunks +101 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jvoung (off chromium)
5 years, 7 months ago (2015-05-26 16:46:49 UTC) #2
Jim Stichnoth
lgtm https://codereview.chromium.org/1156713003/diff/60001/src/IceTargetLoweringARM32.cpp File src/IceTargetLoweringARM32.cpp (right): https://codereview.chromium.org/1156713003/diff/60001/src/IceTargetLoweringARM32.cpp#newcode614 src/IceTargetLoweringARM32.cpp:614: // TODO(sehr,stichnot): minimize the number of adjustments of ...
5 years, 7 months ago (2015-05-26 16:58:55 UTC) #3
jvoung (off chromium)
https://codereview.chromium.org/1156713003/diff/60001/src/IceTargetLoweringARM32.cpp File src/IceTargetLoweringARM32.cpp (right): https://codereview.chromium.org/1156713003/diff/60001/src/IceTargetLoweringARM32.cpp#newcode614 src/IceTargetLoweringARM32.cpp:614: // TODO(sehr,stichnot): minimize the number of adjustments of SP, ...
5 years, 7 months ago (2015-05-26 20:53:47 UTC) #4
jvoung (off chromium)
5 years, 7 months ago (2015-05-26 21:25:50 UTC) #5
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) manually as
55500dbceb14d4223533701158389e89c1f93a5e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698