chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java - Issue 11567061: Throw exception when initialization failed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java

Issue 11567061: Throw exception when initialization failed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove process initialization in ContentViewCore constructor Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java ('K') | « android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java ('k') | chrome/app/android/chrome_main_delegate_android.cc » ('j') | content/app/android/library_loader_hooks.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java

diff --git a/chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java b/chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java

index e754bb83b289591a4ba40b1072236764bdfd181d..97707149054b1ba0d3bc0ae9004c5ab057743b0c 100644

--- a/chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java

+++ b/chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java

@@ -18,6 +18,7 @@ import org.chromium.content.app.LibraryLoader;

import org.chromium.content.browser.ContentView;

import org.chromium.content.browser.DeviceUtils;

import org.chromium.content.common.CommandLine;

+import org.chromium.content.common.ProcessInitException;

import org.chromium.ui.gfx.ActivityNativeWindow;

/**

@@ -40,9 +41,12 @@ public class ChromiumTestShellActivity extends ChromiumActivity {

waitForDebuggerIfNeeded();

DeviceUtils.addDeviceSpecificUserAgentSwitch(this);

- ContentView.initChromiumBrowserProcess(this, ContentView.MAX_RENDERERS_AUTOMATIC);

+ try {

+ ContentView.initChromiumBrowserProcess(this, ContentView.MAX_RENDERERS_AUTOMATIC);

+ } catch (ProcessInitException e) {

+ Log.e(TAG, "Chromium browser process initialization failed", e);

+ finish();

+ }

setContentView(R.layout.testshell_activity);

mTabManager = (TabManager) findViewById(R.id.tab_manager);

String startupUrl = getUrlFromIntent(getIntent());