Throw exception when initialization failed.

android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java

Index: android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java b/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
index 682706a2bd35fcf51f3b6220a94a3ca973dec69b..a31d1b41aacba5f7a7cc3c1bbf4a37ea41d73368 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
@@ -11,6 +11,7 @@ import org.chromium.base.ThreadUtils;
 import org.chromium.content.app.LibraryLoader;
 import org.chromium.content.browser.AndroidBrowserProcess;
 import org.chromium.content.browser.ResourceExtractor;
+import org.chromium.content.common.ProcessInitException;
 
 /**
  * Wrapper for the steps needed to initialize the java and native sides of webview chromium.
@@ -46,9 +47,13 @@ public abstract class AwBrowserProcess {
         ThreadUtils.runOnUiThreadBlocking(new Runnable() {
             @Override
             public void run() {
-                LibraryLoader.ensureInitialized();
-                AndroidBrowserProcess.initContentViewProcess(context,
-                        AndroidBrowserProcess.MAX_RENDERERS_SINGLE_PROCESS);
+                try {
+                    LibraryLoader.ensureInitialized();
+                    AndroidBrowserProcess.initContentViewProcess(context,
+                            AndroidBrowserProcess.MAX_RENDERERS_SINGLE_PROCESS);
+                } catch (ProcessInitException e) {
+                    throw new Error("Cannot initialize WebView", e);

[joth, 2013/01/08 21:20:45]

Unfortunately ThreadUtils.runOnUiThreadBlocking does not propogate Errors back
to the caller, only exceptions.
Coud you update ThreadUtils.runOnUiThreadBlocking to catch Throwable instead of
Exception? (and pass it back through) or just create a RuntimeException here
(maybe more reasonable).

[michaelbai, 2013/01/09 00:14:00]

Used RuntimeException.


On 2013/01/08 21:20:45, joth wrote:

[joth, 2013/01/09 02:51:24]

OK. Was removing  the message intentional? That should work ok with
RuntimeException too. (and seems sufficiently useful to include)

[michaelbai, 2013/01/09 21:04:42]

I were thinking it might be a redundant message, I added it back since you like
it.


On 2013/01/09 02:51:24, joth wrote:

+                }
             }
         });
     }