android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java - Issue 11567061: Throw exception when initialization failed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java

Issue 11567061: Throw exception when initialization failed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove process initialization in ContentViewCore constructor Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java ('K') | « android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java ('k') | chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java » ('j') | content/app/android/library_loader_hooks.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java b/android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java

index 408c2d3f658f3cafc0f158d265f74d3b6a659be2..9fa48683b6ccb1611beeba577fbe1334844028ee 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java

@@ -22,6 +22,7 @@ import org.chromium.content.browser.test.util.CallbackHelper;

import org.chromium.content.browser.test.util.Criteria;

import org.chromium.content.browser.test.util.CriteriaHelper;

import org.chromium.content.browser.test.util.TestCallbackHelperContainer;

+import org.chromium.content.common.ProcessInitException;

import org.chromium.ui.gfx.ActivityNativeWindow;

import java.util.concurrent.atomic.AtomicInteger;

@@ -53,8 +54,12 @@ public class AndroidWebViewTestBase

@Override

public void run() {

AwTestResourceProvider.registerResources(context);

- ContentViewCore.initChromiumBrowserProcess(

- context, ContentView.MAX_RENDERERS_SINGLE_PROCESS);

+ try {

+ ContentViewCore.initChromiumBrowserProcess(

+ context, ContentView.MAX_RENDERERS_SINGLE_PROCESS);

+ } catch (ProcessInitException e) {

+ throw new Error("Failed to initialize browser process", e);

+ }

}

});

}