Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1156573008: Allow OpenApkAsset() to open resource files as well as assets. (Closed)

Created:
5 years, 6 months ago by agrieve
Modified:
5 years, 6 months ago
Reviewers:
nyquist, Torne, rmcilroy
CC:
chromium-reviews, erikwright+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow OpenApkAsset() to open resource files as well as assets. This will be necessary for when language .pak files are moved to res/raw (for apk splits). BUG=394502 Committed: https://crrev.com/62536bc6e789895ea8dbd814b43c49b4479ba4db Cr-Commit-Position: refs/heads/master@{#332998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -17 lines) Patch
M android_webview/browser/aw_browser_main_parts.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M android_webview/native/aw_media_url_interceptor.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/android/apk_assets.h View 1 chunk +4 lines, -2 lines 0 comments Download
M base/android/apk_assets.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M base/android/java/src/org/chromium/base/ApkAssets.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
agrieve
Thought about having two functions: * OpenApkAsset("icudtl.dat") * OpenApkResource("raw/file.pak") but I think having one function ...
5 years, 6 months ago (2015-06-03 01:16:32 UTC) #2
Torne
lgtm
5 years, 6 months ago (2015-06-03 09:43:56 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156573008/1
5 years, 6 months ago (2015-06-03 14:04:01 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-03 16:57:16 UTC) #8
agrieve
On 2015/06/03 16:57:16, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 6 months ago (2015-06-04 19:09:42 UTC) #9
nyquist
base lgtm
5 years, 6 months ago (2015-06-04 20:25:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156573008/1
5 years, 6 months ago (2015-06-05 01:59:34 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 03:01:42 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 03:02:23 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62536bc6e789895ea8dbd814b43c49b4479ba4db
Cr-Commit-Position: refs/heads/master@{#332998}

Powered by Google App Engine
This is Rietveld 408576698