Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2393)

Unified Diff: base/android/apk_assets.h

Issue 1156573008: Allow OpenApkAsset() to open resource files as well as assets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/native/aw_media_url_interceptor.cc ('k') | base/android/apk_assets.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/apk_assets.h
diff --git a/base/android/apk_assets.h b/base/android/apk_assets.h
index f5df35d559dbcefe8a6ba39ab45f9e3b61e6f3ce..6eb5da37354069dbf50f982fc17c26f61c1de7ae 100644
--- a/base/android/apk_assets.h
+++ b/base/android/apk_assets.h
@@ -20,17 +20,19 @@ bool RegisterApkAssets(JNIEnv* env);
// Can be used from renderer process.
// Fails if the asset is not stored uncompressed within the .apk.
// Returns: The File Descriptor of the asset, or -1 upon failure.
+// Input arguments:
+// - |file_path|: Path to file within .apk. e.g.: assets/foo.pak
// Output arguments:
// - |region|: size & offset (in bytes) within the .apk of the asset.
BASE_EXPORT int OpenApkAsset(
- const std::string& filename,
+ const std::string& file_path,
base::MemoryMappedFile::Region* region);
// Registers an uncompressed asset from within the apk with GlobalDescriptors.
// Returns: true in case of success, false otherwise.
BASE_EXPORT bool RegisterApkAssetWithGlobalDescriptors(
base::GlobalDescriptors::Key key,
- const std::string& asset_filename);
+ const std::string& file_path);
} // namespace android
} // namespace base
« no previous file with comments | « android_webview/native/aw_media_url_interceptor.cc ('k') | base/android/apk_assets.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698