Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1487)

Unified Diff: android_webview/browser/aw_browser_main_parts.cc

Issue 1156573008: Allow OpenApkAsset() to open resource files as well as assets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/lib/main/aw_main_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/aw_browser_main_parts.cc
diff --git a/android_webview/browser/aw_browser_main_parts.cc b/android_webview/browser/aw_browser_main_parts.cc
index 4ea656ce92c381c41e5a1c2fa18c14fff4845b14..4e5548ee8db0ee2ffc4b9067f7a3aa6d746ee409 100644
--- a/android_webview/browser/aw_browser_main_parts.cc
+++ b/android_webview/browser/aw_browser_main_parts.cc
@@ -61,7 +61,8 @@ int AwBrowserMainParts::PreCreateThreads() {
base::android::GetDefaultLocale(),
NULL,
ui::ResourceBundle::DO_NOT_LOAD_COMMON_RESOURCES);
- std::string locale = l10n_util::GetApplicationLocale(std::string()) + ".pak";
+ std::string locale =
+ "assets/" + l10n_util::GetApplicationLocale(std::string()) + ".pak";
int pak_fd = base::android::OpenApkAsset(locale, &pak_region);
if (pak_fd != -1) {
ui::ResourceBundle::CleanupSharedInstance();
@@ -74,7 +75,8 @@ int AwBrowserMainParts::PreCreateThreads() {
// Try to directly mmap the webviewchromium.pak from the apk. Fall back to
// load from file, using PATH_SERVICE, otherwise.
- pak_fd = base::android::OpenApkAsset("webviewchromium.pak", &pak_region);
+ pak_fd = base::android::OpenApkAsset("assets/webviewchromium.pak",
+ &pak_region);
if (pak_fd != -1) {
ui::ResourceBundle::GetSharedInstance().AddDataPackFromFileRegion(
base::File(pak_fd), pak_region, ui::SCALE_FACTOR_NONE);
« no previous file with comments | « no previous file | android_webview/lib/main/aw_main_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698