Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: webkit/media/webmediaplayer_impl.cc

Issue 11564007: Move AudioRendererImpl construction to WebMediaPlayerImpl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase only Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/media/webmediaplayer_impl.cc
diff --git a/webkit/media/webmediaplayer_impl.cc b/webkit/media/webmediaplayer_impl.cc
index f5e63331a239b83b285e7a5aa1b881c4b48036b5..9e907e11782aa3cc51cfd7e77a546a28dbf99e3f 100644
--- a/webkit/media/webmediaplayer_impl.cc
+++ b/webkit/media/webmediaplayer_impl.cc
@@ -188,9 +188,12 @@ WebMediaPlayerImpl::WebMediaPlayerImpl(
filter_collection_->AddVideoRenderer(video_renderer);
proxy_->set_frame_provider(video_renderer);
- // Create default audio renderer.
+ // Create default audio renderer using the null sink if no sink was provided.
+ if (!audio_renderer_sink) {
+ audio_renderer_sink = new media::NullAudioSink();
+ }
filter_collection_->AddAudioRenderer(
- new media::AudioRendererImpl(new media::NullAudioSink()));
+ new media::AudioRendererImpl(audio_renderer_sink));
if (WebKit::WebRuntimeFeatures::isEncryptedMediaEnabled()) {
decryptor_.reset(new ProxyDecryptor(message_loop_factory_->GetMessageLoop(
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698